Giter VIP home page Giter VIP logo

Comments (13)

karx1 avatar karx1 commented on May 22, 2024 1

Alright, I'll do those things.

from domecode-opensource.

arthtyagi avatar arthtyagi commented on May 22, 2024 1

the navbar appears transparent only when using safari I guess and that's in the proprietary code. drop the transparency issue, I'll be rolling the fix with some other features. Just try fixing the issues in the open-source version, I'll inherit the fixes from them in the proprietary code base if they seem alright and update the open-source repo with up-to-date code.

from domecode-opensource.

karx1 avatar karx1 commented on May 22, 2024

I can try and help with this if you assign this issue to me!

from domecode-opensource.

karx1 avatar karx1 commented on May 22, 2024

Ok, so, after some testing, turns out that DomeCode is actually pretty responsive on mobile. However, I did notice one graphical glitch, (the "cards" don't align to the center) which I will try to fix.

from domecode-opensource.

arthtyagi avatar arthtyagi commented on May 22, 2024

Yeah they don't. Another thing, create a local superuser for yourself. Go to the admin and create a resource with a video inside it. The video embed isn't responsive either in the Resources.
Have a look at https://domecode.com/tracks/python/stacks-and-queues/ on a mobile device.
In addition to it, the navbar looks really generic, try making it more minimalistic and modern on the mobile devices and as for larger screens, try resizing the browser window and look at how unresponsive the header is. That can be fixed.

from domecode-opensource.

arthtyagi avatar arthtyagi commented on May 22, 2024

any updates?

from domecode-opensource.

karx1 avatar karx1 commented on May 22, 2024

Hey! Sorry for not getting back to you on this. Work is currently underway to try and re-center the "cards" and fix the video issue. Once those are done, I'll have a look at the resizing issue. Also, the navbar appears transparent on mobile, and so does the drop-down when expanded. I'll see if I can try to fix it.

from domecode-opensource.

karx1 avatar karx1 commented on May 22, 2024

from domecode-opensource.

arthtyagi avatar arthtyagi commented on May 22, 2024

ah okay it's alright tbh, I know the fix for it plus the code causing transparency is not in the open-source repo at the moment.

from domecode-opensource.

karx1 avatar karx1 commented on May 22, 2024

Hey, I made a pull request with a requirements.txt file. Please review it and let me know of any changes that might need to be made.

from domecode-opensource.

karx1 avatar karx1 commented on May 22, 2024

@arthtyagi Hey, you mentioned something about a fix for the resources issue, but you said you'd have to do it manually for each resource. Can you send me that code? I want to see if I can make it so that it applies automatically to each resource.

from domecode-opensource.

arthtyagi avatar arthtyagi commented on May 22, 2024

This is the iframe : <iframe frameborder="0" height="610" scrolling="no" src="https://www.youtube-nocookie.com/embed/p-_DFOyEMV8" width="1080"></iframe>

and this is the fix :

<div class="video-container"> <iframe frameborder="0" height="610" scrolling="no" src="https://www.youtube-nocookie.com/embed/p-_DFOyEMV8" width="1080"></iframe>   </div>  <style> .video-container { position:relative; padding-bottom:56.25%; padding-top:30px; height:0; overflow:hidden; } .video-container iframe, .video-container object, .video-container embed { position:absolute; top:0; left:0; width:100%; height:100%; }  </style>

from domecode-opensource.

karx1 avatar karx1 commented on May 22, 2024

Alright, I'll see what I can do.

from domecode-opensource.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.