Giter VIP home page Giter VIP logo

Comments (5)

the-simian avatar the-simian commented on June 22, 2024

thanks for the report, @Lokiem , are these two separate issues?

from es6-plato.

Lokiem avatar Lokiem commented on June 22, 2024

They may be related, as the result of the regex match is used for the popover JS.

The popover being cutoff is related to the container property of the popover function (Currently not set, so I would assume it's defaulting to it's parent, which looks to be .CodeMirror as it has a overflow:hidden), if that property is set to body then the cutoff is fixed, though linespacing on the popover is a little larger.

I couldn't figure out what was causing the popover to irregularly not work, but I'm willing to assume it may have just been one of the tweaks I was making to get the other parts working. On running a clean plato, and just adding the small changes I've outlined I didn't have any issues with the popovers.

from es6-plato.

the-simian avatar the-simian commented on June 22, 2024

Ok let me try out that regext - see if it catches all the functions. I want to see if I can reproduce the problem and the fix. Appreciate the feedback, @Lokiem

I can't get to it for a while; however, if you manage to make a Pull request with the proposed changes I will happily pull it in.

from es6-plato.

the-simian avatar the-simian commented on June 22, 2024

@Lokiem I updated the deps and am doing some testing

from es6-plato.

the-simian avatar the-simian commented on June 22, 2024

@Lokiem the deps are updated again, I'm closing this but if it is still giving you problems lmk and I'll repoen

from es6-plato.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.