Giter VIP home page Giter VIP logo

Comments (6)

paulvarache avatar paulvarache commented on May 28, 2024 2

Thanks, the description helped. I have just updated the package with a fix for this. It is availabel under 1.0.0

@troy-ob As you suspected, the Horizontal padding wasn't removed from the availableWidth when calculating the ContentDetentHeight

Let me know if that solves your issue

from the49.maui.bottomsheet.

troy-ob avatar troy-ob commented on May 28, 2024 1

Hi,
the issue still persists for me, on Android at least.

Setup:

  • ContentDetent
  • Label with lots of text in the BottomSheet
  • rc12

Image1 with BottomSheet Paddings 32, 32, 32, 40
image

Image2 with BottomSheet Paddings 0, 32, 0, 40
image

You can see in Image 1 that the BottomPadding is lost (or at least off screen). If I remove the paddings left and right, the BottomPadding is still applied correctly. I think that the BottomSheet-height is calculated before paddings left and right are considered -> content is shifted downwards and partly off screen.

from the49.maui.bottomsheet.

troy-ob avatar troy-ob commented on May 28, 2024 1

Thanks @paulvarache, that fixed the issue :)

from the49.maui.bottomsheet.

DiogoDeAlmeida avatar DiogoDeAlmeida commented on May 28, 2024

I juste tried the last version "1.0.0-rc5".

It seems the Android version work now correctly but i have still the issue on iOS.

from the49.maui.bottomsheet.

troy-ob avatar troy-ob commented on May 28, 2024

I have the same issue and I think I know what is the cause. I think the content height is calculated before padding-left and padding-right are considered. And because the paddings cause the label to break into lines differently, it miscalculates. You could try to remove the paddings left/right and see how it behaves. However, not having these paddings is not optimal.

At least that's how it is like on my end with rc-9.

from the49.maui.bottomsheet.

paulvarache avatar paulvarache commented on May 28, 2024

Hi,

I wasn't sure what this issue was about exactly. I assumed this meant that when using the ContentDetent and the content of the sheet gets resize (e.g. label text changes), the sheet on iOS wasn't adapting to the new size.

I have just pushed a fix for what I just described, it'll be available under rc12. You might nee to manually set this version as nuget doesn't offer updates since rc10.

If this wasn't the issue, let me know in more details the problems you're having

from the49.maui.bottomsheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.