Comments (6)
Thanks, the description helped. I have just updated the package with a fix for this. It is availabel under 1.0.0
@troy-ob As you suspected, the Horizontal padding wasn't removed from the availableWidth when calculating the ContentDetentHeight
Let me know if that solves your issue
from the49.maui.bottomsheet.
Hi,
the issue still persists for me, on Android at least.
Setup:
- ContentDetent
- Label with lots of text in the BottomSheet
- rc12
Image1 with BottomSheet Paddings 32, 32, 32, 40
Image2 with BottomSheet Paddings 0, 32, 0, 40
You can see in Image 1 that the BottomPadding is lost (or at least off screen). If I remove the paddings left and right, the BottomPadding is still applied correctly. I think that the BottomSheet-height is calculated before paddings left and right are considered -> content is shifted downwards and partly off screen.
from the49.maui.bottomsheet.
Thanks @paulvarache, that fixed the issue :)
from the49.maui.bottomsheet.
I juste tried the last version "1.0.0-rc5".
It seems the Android version work now correctly but i have still the issue on iOS.
from the49.maui.bottomsheet.
I have the same issue and I think I know what is the cause. I think the content height is calculated before padding-left and padding-right are considered. And because the paddings cause the label to break into lines differently, it miscalculates. You could try to remove the paddings left/right and see how it behaves. However, not having these paddings is not optimal.
At least that's how it is like on my end with rc-9.
from the49.maui.bottomsheet.
Hi,
I wasn't sure what this issue was about exactly. I assumed this meant that when using the ContentDetent and the content of the sheet gets resize (e.g. label text changes), the sheet on iOS wasn't adapting to the new size.
I have just pushed a fix for what I just described, it'll be available under rc12. You might nee to manually set this version as nuget doesn't offer updates since rc10.
If this wasn't the issue, let me know in more details the problems you're having
from the49.maui.bottomsheet.
Related Issues (20)
- Is it possible to have a bottom sheet portion always presented at the bottom of the page ? HOT 1
- [iOS] Height is calculated incorrectly on iPad
- Failed nuget package publication
- Snackbar showing fail.
- Potential memory leak
- Is it possible to have a Handle, but disable dismiss by it?
- Navigation issue HOT 3
- View Model Dismiss Async HOT 2
- Support for razor component
- How to add a title view ? (<Shell.TitleView> not working)
- dismissing with the left swipe gesture on android does not close the modal dialog (HasBackdrop is true) HOT 1
- Entry / Editor Crashes When Focussed HOT 3
- iOS 15.8 Detents Not Working HOT 1
- Invalid cast exception on android
- binding isnt work from viewmodel to bottomsheet
- RadioButton in Bottomsheet
- Has something changed?
- Status Bar colour changes to white when opening a bottom sheet
- bottomsheet behind tabbar
- Handle not being shown.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from the49.maui.bottomsheet.