Comments (6)
I'd propose switching to vitest, instead! It's definitely more Jest-compatible and should speed up test execution quite substantially, too. If you wand, I'd gladly provide a PR 😎
Sounds good!
from javascript.
Alternatively, we could also say we're sticking with "vanilla" Node.js but we'll update to Node 20 (and potentially update a ton of deps and clean up the codebase a bit).
from javascript.
I'm not opposed to switching to Bun, assuming everything continues working as before, esp. if it helps improve performance (this is more of a small-ish benefit, though, at least for me as a reviewer; it may be more useful for our contributors).
A small concern is that this might make the repo slightly harder to work with for newcomers (Node.js is more common, will typically be available in your package manager / there will be easy install guides, etc.)
I also can't judge the maturity of Bun.
Updating deps & the Node version is a chore which I don't think is necessary yet (but of course I wouldn't mind it). Updating Node also may come at slight contributor inconvenience again (e.g. if the newer Node version hasn't been packaged on their distro yet).
from javascript.
Thanks for your insights! 🙏
I've been playing around a bit with Bun in this codebase and here are my two cents: We're not "really" using the runtime other than for executing the tests themselves and therefore might not even be benefiting from a switch to Bun at all.
We could just leave everything as-is and just run Jest with Bun instead of Node.js. In this case, there is no or just a negligible speedup. => I don't see the point in migrating just for the sake of migrating.
We could also try to migrate to using Bun's own test runner - that one is ridiculously fast. But since it's not fully supporting the API provided by Jest (at the moment), this would actually break a lot of our tests. => Absolute no-go.
I'd propose switching to vitest, instead! It's definitely more Jest-compatible and should speed up test execution quite substantially, too. If you want, I'd gladly provide a PR 😎
from javascript.
Especially thinking about keeping the repo to stay as newcomer-friendly as possible: Agreed that it's most likely more robust to just stick with Node / NPM and utilize awesome stuff like vitest, instead.
from javascript.
Regarding the version of node: Node 20 will be the "active LTS" release starting this October - see the releases page. Defining (i.e. expecting) Node 20 makes total sense. It should be easily available for everyone.
from javascript.
Related Issues (20)
- chore: fix / clean up jsdoc comments HOT 13
- Fet: add "M-Coloring" Problem in Backtracking HOT 1
- Fet: Octal To Binary Convertor HOT 1
- Fet: Added "Octal To Binary" in Coversion Section HOT 1
- [OTHER]: It is not looks good for create a separate section for connect with us section. HOT 1
- [FEATURE]: Last Element HOT 6
- [FEATURE]: Height of tree HOT 3
- [Question]: How can i work on multiple file? do i have to wait for first pr to be merged? HOT 1
- [FEATURE]: Length Conversion HOT 1
- [FEATURE]: HOT 2
- [FEATURE]: Add a palindrome validating code in the "string" folder under Hacktoberfest HOT 3
- [OTHER]: Grammar Mistake HOT 1
- [OTHER]: Add gidpod ready to code badge in README.md HOT 1
- [FEATURE]: DISJOINT SET
- Backtracking HOT 1
- [FEATURE]: Data structure, Disjoint Set HOT 1
- [FEATURE]: Hash Table Data Structure HOT 1
- [FEATURE]: Adding A workflow insuring including JSDOCS on every PR HOT 3
- [OTHER]: Duplicate entry of sieve of eratosthenes HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from javascript.