Comments (8)
Will release v5.3.0 then
from fdir.
One small piece of unsolicited feedback, is that this might fall into the boolean trap.
I agree. I'll be making some breaking changes in v6.0 so this API is definitely not final. There's a lot of confusion in the current exposed methods so I will do some much needed renaming as well.
from fdir.
WIP at #84
from fdir.
@IanVS can you test against master branch and see if that works for you?
from fdir.
Yep, I copied over the src
from master and it's now working correctly! Thanks!
from fdir.
@IanVS done. I changed the API a bit to be backwards compatible with v5 so check the docs to see how you can use it.
from fdir.
Thanks. One small piece of unsolicited feedback, is that this might fall into the boolean trap. When reading .withSymlinks(false)
it could reasonably be thought that symlinks are disabled. An API like .withSymlinks({ resolve: boolean })
gives a bit more clarity, IMHO. But, that's just my own two cents. Thanks again for getting this released so quickly!
from fdir.
Related Issues (20)
- Remove callback API in next major HOT 1
- v7.0 Plan HOT 7
- Need to list path to symlink instead of resolved path HOT 2
- Limit files option HOT 1
- Need help debugging an issue?? with fdir HOT 4
- What's the correct way to use globbing? HOT 2
- Crawl with options group interface no longer correct in v5.2.0 (v5.1.0 was the same) HOT 1
- Ideas for mocking HOT 1
- Sorting based on date, name, size etc
- Issue with SharePoint project accessible over the network HOT 2
- Invalid reference of TypeScript types HOT 2
- Feature request: pass picomatch to the builder HOT 3
- Avoiding double backslash HOT 1
- Corner case when globbing current directory returns zero results HOT 1
- Problem with double Backslash on Windows
- Bug: Module '"picomatch"' has no exported member 'PicomatchOptions'. HOT 1
- Add `fs.readdir` with `{ recursive: true }` to benchmarks HOT 5
- Support picomatch v4
- Support Browser out of the box HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fdir.