Comments (7)
Should we track some ideas here? For instance, contributions now require each added / modified function to be properly documented (maybe tested as well?)
from inkwell.
I've added a PR template. Feel free to provide feedback here on format or content next time you submit a PR.
from inkwell.
It's nice, but I find it a little overwhelming. It looks like it was made for pretty huge commits, and a simple fix or doc change for example requires a pretty long form to be submitted.
from inkwell.
from inkwell.
- The checklist could instead be a single checkbox that reads "I have read the [Contributing guide](./CONTRIBUTING.md)" or, since GitHub automatically shows a message referring to it, the checklist could be completely removed.
- "Motivation and Context" doesn't seem extremely relevant. "Why is this change required? What problem does it solve?" are self-explanatory (either through the description, or thanks to the related issue).
- Some parts should be explicitly optional. For example, an additional "Breaking changes" part would be useful if breaking changes are introduced, and would render the "Types of Change" part useless (since whether it's a bug fix or feature change is answered in the related issue).
Finally, this is a personal preference, but I think moving contribution documents (PR template, Contributing, etc) to /.github
is better (it clearly separates the Rust part from the GitHub part).
from inkwell.
Those are all great points. Will take them into consideration. Thanks!
from inkwell.
Addressed COC 4ef6045 and issue templates 7bdd870
from inkwell.
Related Issues (20)
- ORC support HOT 1
- Const struct member access HOT 1
- Segfault when using `module.create_jit_execution_engine()` HOT 2
- Named keys on debug struct types HOT 1
- Adding get_allocated_type, is_terminator and is_conditional to InstructionValue HOT 1
- Add a function to add llvm ir directly HOT 1
- after importing LLVM IR, a segmentation fault occurs when calling its internal method HOT 2
- Restricting build_*_gep to make it safer. HOT 1
- Add more constants for dwarf flags HOT 2
- Implement `Clone + Copy` for `ContextRef` HOT 2
- Support for `llvm::orc2::LLJit` HOT 1
- Solution: Inkwell Rust LLVM_SYS not set VSCODE
- `UnsafeFunctionPointer::Args` as a convienence. HOT 2
- [...]/libllvm_sys-af2874cb0b33780b.rlib: error adding symbols: file format not recognized HOT 1
- Support LLVM 18.1
- `Context::metadata_string` doc example returns an error
- rename `build_bitcast` to `build_bit_cast` HOT 1
- Wrong thread-safety trait implementing on LLVMString HOT 3
- Add set_opaque_pointers to Context
- Can't find Polly :( (tried the other posted issue too ) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inkwell.