Giter VIP home page Giter VIP logo

Comments (7)

71 avatar 71 commented on May 25, 2024 1

Should we track some ideas here? For instance, contributions now require each added / modified function to be properly documented (maybe tested as well?)

from inkwell.

TheDan64 avatar TheDan64 commented on May 25, 2024

I've added a PR template. Feel free to provide feedback here on format or content next time you submit a PR.

from inkwell.

71 avatar 71 commented on May 25, 2024

It's nice, but I find it a little overwhelming. It looks like it was made for pretty huge commits, and a simple fix or doc change for example requires a pretty long form to be submitted.

from inkwell.

TheDan64 avatar TheDan64 commented on May 25, 2024

from inkwell.

71 avatar 71 commented on May 25, 2024
  1. The checklist could instead be a single checkbox that reads "I have read the [Contributing guide](./CONTRIBUTING.md)" or, since GitHub automatically shows a message referring to it, the checklist could be completely removed.
  2. "Motivation and Context" doesn't seem extremely relevant. "Why is this change required? What problem does it solve?" are self-explanatory (either through the description, or thanks to the related issue).
  3. Some parts should be explicitly optional. For example, an additional "Breaking changes" part would be useful if breaking changes are introduced, and would render the "Types of Change" part useless (since whether it's a bug fix or feature change is answered in the related issue).

Finally, this is a personal preference, but I think moving contribution documents (PR template, Contributing, etc) to /.github is better (it clearly separates the Rust part from the GitHub part).

from inkwell.

TheDan64 avatar TheDan64 commented on May 25, 2024

Those are all great points. Will take them into consideration. Thanks!

from inkwell.

TheDan64 avatar TheDan64 commented on May 25, 2024

Addressed COC 4ef6045 and issue templates 7bdd870

from inkwell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.