Giter VIP home page Giter VIP logo

Comments (7)

Marius1311 avatar Marius1311 commented on August 26, 2024

on hold.

from moscot.

Marius1311 avatar Marius1311 commented on August 26, 2024

@michalk8 agreed to look into this a bit.

from moscot.

michalk8 avatar michalk8 commented on August 26, 2024

The problem is here: https://github.com/theislab/moscot/blob/dev/moscot/_solver.py#L45
geom.cost_matrix is None when online=True. The Transport object than tries to access self.geometry.shape, which throws the above error. Not sure if not passing both cost/kernel is by design (or passing both and later ignoring kernel matrix), can't find any, except for coyping eps from another temp. geometry to the current one - can be useful and that's what I should've done in the above example. Imho, not really a bug, but a feature. Minimal reproducible example:

from ott.geometry.geometry import Geometry
Geometry().shape

from moscot.

Marius1311 avatar Marius1311 commented on August 26, 2024

Ok, should we

  • close this or
  • open an issue in OTT?

from moscot.

Marius1311 avatar Marius1311 commented on August 26, 2024

@MUCDK, can we move this issue to OTT and close it here?

from moscot.

Marius1311 avatar Marius1311 commented on August 26, 2024

Or just close if it's no longer relevant please.

from moscot.

MUCDK avatar MUCDK commented on August 26, 2024

I think we can close it for now, we could think about catching the error ourselves.

from moscot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.