Comments (7)
on hold.
from moscot.
@michalk8 agreed to look into this a bit.
from moscot.
The problem is here: https://github.com/theislab/moscot/blob/dev/moscot/_solver.py#L45
geom.cost_matrix
is None
when online=True
. The Transport
object than tries to access self.geometry.shape
, which throws the above error. Not sure if not passing both cost/kernel is by design (or passing both and later ignoring kernel matrix), can't find any, except for coyping eps
from another temp. geometry to the current one - can be useful and that's what I should've done in the above example. Imho, not really a bug, but a feature. Minimal reproducible example:
from ott.geometry.geometry import Geometry
Geometry().shape
from moscot.
Ok, should we
- close this or
- open an issue in OTT?
from moscot.
@MUCDK, can we move this issue to OTT and close it here?
from moscot.
Or just close if it's no longer relevant please.
from moscot.
I think we can close it for now, we could think about catching the error ourselves.
from moscot.
Related Issues (20)
- Future broken tests HOT 1
- Highlight moslin HOT 3
- Add names of base methods in corresponding problem classes
- Shall we remove TedSim simulation data? HOT 1
- get same output when pulling/pushing a vector on problem level or solution level
- Undefined variable `mask_2`
- Not a huge priority, but would consider adding a type alias for this and modifying to:
- Enable passing solutions to problems
- LineageClass broken HOT 3
- Add an option to force downloading datasets
- Make resolution of sankey strips a variable
- Expose the `scaling` parameter in `estimate_marginals`. HOT 2
- Correct docs of cell_transition HOT 1
- Parameters of Temporal Problem to use in atlassing context HOT 7
- Error retrieving `prior_growth_rates` from `TemporalProblem` HOT 1
- Update pandas version HOT 1
- Fix linting in `moscot_notebooks`
- Test for the correct use of parameters of ott-jax which are not exposed in moscot HOT 1
- Add a warning to `output.set_solution` that transport matrix will be instantiated
- Computing proliferation and apoptosis scores. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moscot.