Refactor: Maybe GW should inherit from FGW instead of vice versa about moscot HOT 2 OPEN

so you would then throw NotImplementedError for all functions which are specific to the fused term?

from moscot.

But this problem also exists in current code. I can currently run

gwp[('0','1')].set_x(...)

because gwp[('0','1')] is a OTProblem, gwp itself doesn't have set_xy and others. If you are talking about other methods, I didn't notice any method that only FGWProblem itself implements except these

    @property
    def _base_problem_type(self) -> Type[B]:
        return OTProblem  # type: ignore[return-value]

    @property
    def _valid_policies(self) -> Tuple[Policy_t, ...]:
        return _constants.SEQUENTIAL, _constants.EXPLICIT, _constants.STAR  # type: ignore[return-value]

which are the same for both. So moving these to the parent class should work always.

from moscot.