Giter VIP home page Giter VIP logo

Comments (7)

Jemaz avatar Jemaz commented on May 23, 2024 1

@vsemozhetbyt Thanks truly for the formatting advice!
So there's a couple things wrong with it as I was doing the tutorial:

  1. The section is basically turning global vars into local vars by turning into functions (as I understood to eliminate any side-effects), the author did so except for the anonymous function "nolanMovies" which defeats the purpose of the exercise - which confused like a beginner like me
  2. It's missing a return statement

from thejsway.

vsemozhetbyt avatar vsemozhetbyt commented on May 23, 2024 1

@Jemaz I suppose both using the global variable and omitting the return are intended to show how a not pure function operates. It is a bit dizzying from the final point of view, but maybe this is the very sense of it)

from thejsway.

vsemozhetbyt avatar vsemozhetbyt commented on May 23, 2024 1

What was a bit more confusing for me: why the final byNolan() was not refactoring into the more generic byDirector(director). But this can also be intended to make the transition from the old code to the new one more smooth.

from thejsway.

Jemaz avatar Jemaz commented on May 23, 2024

Excuse me for the bad formatting, still a newb to this.

from thejsway.

vsemozhetbyt avatar vsemozhetbyt commented on May 23, 2024

@Jemaz It seems this function uses the global variable that is declared below in that code fragment:

//...
const nolanMovieList = [];

console.log(titles());
// ...

from thejsway.

vsemozhetbyt avatar vsemozhetbyt commented on May 23, 2024

@Jemaz About formatting, you can read here:

https://help.github.com/articles/creating-and-highlighting-code-blocks/

Just use js or javascript label instead of ruby from the example in that help chapter)

from thejsway.

bpesquet avatar bpesquet commented on May 23, 2024

Thanks for your feedback. This chapter gave me a lot of headaches and is probably still too confusing. I leave this issue open in case someone else can provide good advice for improving it.

from thejsway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.