Comments (3)
These are the 2 main ones in terms of functionality that Shuo had that we don't. Obviously, the theme selector should probably be a bit better (if we integrate it with @astorije and my plan for packages, we don't need to update the config, etc) but afaik, these are the only real "functionality" ones that haven't been merged in.
from thelounge.
- Regarding the "Show timestamp" toggle, I had some concerns in the original PR: erming/shout#484 It definitely should be added here but after addressing them.
- Theme selector seems to be a killer feature for plenty of folks, which I can understand. So I propose that we stick to the plan of having themes been handled like packages (although we would still leave the user choose the theme among those installed by the admin), but in the meantime a simple theme selector would do and provide minimum viable feature for the users. What do you think?
Thanks for digging through the commits! I have no idea how you efficiently went through the changes...
from thelounge.
Just doing a quick look through some old issues. I'm going to close this There was just the 2 mentioned above. The first is #186 and the second could be included in #85. If anyone thinks the theme selector should be a seperate issue, feel free to create it.
from thelounge.
Related Issues (20)
- Edit last message HOT 6
- Client certificate fingerprint not easily available HOT 6
- Please add Casino to TL
- Emoji Rendering Issues HOT 7
- sqlite: clearing a search issues a search query to the DB
- reverse DNS lookup failure crashes TL HOT 3
- The Lounge is very good! HOT 1
- Search input box draws on top of "show more" button
- Use WAL mode for sqlite log? HOT 1
- Error: Failed to write user log: Error: EMFILE: too many open files HOT 1
- Remember channel password HOT 3
- Channel cooldown on join is not actioned HOT 5
- CTCP VERSION response handling HOT 6
- (Minor visual bug) Text input field grows when entering text at 150%+ zoom when it shouldn't HOT 2
- Cant send message to #Bangladesh
- Ignored Security Issue: Hacked by the network HOT 1
- Update web manifest to include screenshots and new icons HOT 2
- Cannot connect from external network HOT 4
- Enviroment variable ignored HOT 3
- Ability to toggle link preview per channel HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thelounge.