Giter VIP home page Giter VIP logo

Comments (3)

AlMcKinlay avatar AlMcKinlay commented on May 22, 2024

These are the 2 main ones in terms of functionality that Shuo had that we don't. Obviously, the theme selector should probably be a bit better (if we integrate it with @astorije and my plan for packages, we don't need to update the config, etc) but afaik, these are the only real "functionality" ones that haven't been merged in.

from thelounge.

astorije avatar astorije commented on May 22, 2024

@YaManicKill:

  • Regarding the "Show timestamp" toggle, I had some concerns in the original PR: erming/shout#484 It definitely should be added here but after addressing them.
  • Theme selector seems to be a killer feature for plenty of folks, which I can understand. So I propose that we stick to the plan of having themes been handled like packages (although we would still leave the user choose the theme among those installed by the admin), but in the meantime a simple theme selector would do and provide minimum viable feature for the users. What do you think?

Thanks for digging through the commits! I have no idea how you efficiently went through the changes...

from thelounge.

AlMcKinlay avatar AlMcKinlay commented on May 22, 2024

Just doing a quick look through some old issues. I'm going to close this There was just the 2 mentioned above. The first is #186 and the second could be included in #85. If anyone thinks the theme selector should be a seperate issue, feel free to create it.

from thelounge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.