Giter VIP home page Giter VIP logo

Comments (4)

goloroden avatar goloroden commented on June 27, 2024

Thanks for reporting this issue, we'll have a look at it, and get back to you.

Please give us a little time for this.

from roboter.

goloroden avatar goloroden commented on June 27, 2024

Okay, let's split this issue into three separate tasks:

Stop publishing when analyze fails

This is already the default behavior. You can not publish anything if it fails code analysis and / or tests. So there is no need to change anything here.

Stop publishing when outdated fails

This does not make sense, IMHO. It does not break anything, and it does not do any harm. It's just that you do not use the latest versions. Hence it is a warning. This will stay this way, especially because it happens from time to time that you can not yet update. Hence it is useful to get this warning every time, but you should be able to publish nonetheless. It's not a show stopper (other than a failed code analysis).

Stop publishing when unused-dependencies fails

On this, you are right: Publishing should stop here, because it just does not make sense to publish a module with a non-needed sub-module. It only increases install time unnecessarily. In case there is a false positive there is the option to exclude specific modules from the check (this check already existed in the past), so that's easy to fix here. The default behavior is now changed, so when any unused dependencies are found, publishing stops.

from roboter.

 avatar commented on June 27, 2024

Stop publishing when unused-dependencies fails

[...]
In case there is a false positive there is the option to exclude specific modules from the check (this check already existed in the past), so that's easy to fix here. The default behavior is now changed, so when any unused dependencies are found, publishing stops.

how do I exclude a module? we have a module mentioned in package.json, delivering a team-specific eslint-config, so that is never referenced in source files. the exclude option in task('universal/unused-dependencies', { does not help here.

from roboter.

goloroden avatar goloroden commented on June 27, 2024

This is currently a bug that I'm working on.
Right now, the only solution is to stick to an old version of roboter.

Sorry for that :-(

from roboter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.