Comments (4)
Thanks for reporting this issue, we'll have a look at it, and get back to you.
Please give us a little time for this.
from roboter.
Okay, let's split this issue into three separate tasks:
Stop publishing when analyze
fails
This is already the default behavior. You can not publish anything if it fails code analysis and / or tests. So there is no need to change anything here.
Stop publishing when outdated
fails
This does not make sense, IMHO. It does not break anything, and it does not do any harm. It's just that you do not use the latest versions. Hence it is a warning. This will stay this way, especially because it happens from time to time that you can not yet update. Hence it is useful to get this warning every time, but you should be able to publish nonetheless. It's not a show stopper (other than a failed code analysis).
Stop publishing when unused-dependencies
fails
On this, you are right: Publishing should stop here, because it just does not make sense to publish a module with a non-needed sub-module. It only increases install time unnecessarily. In case there is a false positive there is the option to exclude specific modules from the check (this check already existed in the past), so that's easy to fix here. The default behavior is now changed, so when any unused dependencies are found, publishing stops.
from roboter.
Stop publishing when unused-dependencies fails
[...]
In case there is a false positive there is the option to exclude specific modules from the check (this check already existed in the past), so that's easy to fix here. The default behavior is now changed, so when any unused dependencies are found, publishing stops.
how do I exclude a module? we have a module mentioned in package.json, delivering a team-specific eslint-config, so that is never referenced in source files. the exclude
option in task('universal/unused-dependencies', {
does not help here.
from roboter.
This is currently a bug that I'm working on.
Right now, the only solution is to stick to an old version of roboter.
Sorry for that :-(
from roboter.
Related Issues (20)
- Non-strict dependency test crashes when non-strict dependencies are found
- Support mocharc.js in addition to mocharc.json for test types.
- Colorize analyse results HOT 2
- Skipping license check – a good idea? HOT 5
- AGPL is not recognised by code analysis. HOT 11
- Validate license strictly if no configuration file exists
- Document roboter context in mocha suites
- Make compatible licenses configuration optional
- Automatically fix the order of properties in `package.json` during `qa`.
- Check of tsconfig.json don't recognised extendes config HOT 1
- Test Watch-Mode crashes on syntax errors
- Bug: roboter test failes without a message on typescript compilation failures
- The typecheck of `roboter analyze` requires an output configuration in `tsconfig.json`. HOT 1
- The analyze task can't find the package.json file if it contains a syntax error
- Not working with npm workspaces? HOT 4
- CC-BY/Artistic licenses and Compatibility HOT 3
- `test` command fails with `typescript >= 4.7`
- pinned peer dependencies create unresolvable dependencie cycle
- Cannot handle comments in json files HOT 1
- Using MIT License sscs-parser is reported to use incaompatible license HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roboter.