Giter VIP home page Giter VIP logo

Comments (12)

gcbishal avatar gcbishal commented on June 5, 2024 1

I have made a pull request. Check it out. And Thanks for building a wonderful widget.

from flutter_polls.

gcbishal avatar gcbishal commented on June 5, 2024

Package update required

Fixed ✔️

final List<dynamic> pollOptions;
to
final List<PollOption> pollOptions;

or cast dynamic to PollOption instance while reducing the options

from flutter_polls.

thenifemi avatar thenifemi commented on June 5, 2024

Hi, sorry, I don't understand the issue. Could you explain better?

from flutter_polls.

jalchr avatar jalchr commented on June 5, 2024

I'm facing the same issue.
Once I tap on_Voted is triggered causing this error

@gcbishal changed line #94

from flutter_polls.

thenifemi avatar thenifemi commented on June 5, 2024

onVoted should be implemented this way: onVoted: (PollOption pollOption, int newTotalVotes) { }

from flutter_polls.

gcbishal avatar gcbishal commented on June 5, 2024

onVoted should be implemented this way: onVoted: (PollOption pollOption, int newTotalVotes) { }

Yeah better just swap the dynamic to PollOption.

from flutter_polls.

thenifemi avatar thenifemi commented on June 5, 2024

onVoted should be implemented this way: onVoted: (PollOption pollOption, int newTotalVotes) { }

Yeah better just swap the dynamic to PollOption.

Yeah, I have tried that but since devs would pass dynamic lists and not PollOption, it would also throw a type error

from flutter_polls.

gcbishal avatar gcbishal commented on June 5, 2024

onVoted should be implemented this way: onVoted: (PollOption pollOption, int newTotalVotes) { }

And the voted poll changes without the new value. It also needs to be fixed.

from flutter_polls.

gcbishal avatar gcbishal commented on June 5, 2024

onVoted should be implemented this way: onVoted: (PollOption pollOption, int newTotalVotes) { }

Yeah better just swap the dynamic to PollOption.

Yeah, I have tried that but since devs would pass dynamic lists and not PollOption, it would also throw a type error

I just changed the pollOption instance field with PollOption type rather than dynamic. And it's working fine. Not having any issue

from flutter_polls.

thenifemi avatar thenifemi commented on June 5, 2024

onVoted should be implemented this way: onVoted: (PollOption pollOption, int newTotalVotes) { }

And the voted poll changes without the new value. It also needs to be fixed.

Could you elaborate on this?

from flutter_polls.

thenifemi avatar thenifemi commented on June 5, 2024

onVoted should be implemented this way: onVoted: (PollOption pollOption, int newTotalVotes) { }

Yeah better just swap the dynamic to PollOption.

Yeah, I have tried that but since devs would pass dynamic lists and not PollOption, it would also throw a type error

I just changed the pollOption instance field with PollOption type rather than dynamic. And it's working fine. Not having any issue

And how are you passing your PollOption data?

from flutter_polls.

thenifemi avatar thenifemi commented on June 5, 2024

@gcbishal Thanks for your contribution 🚀

from flutter_polls.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.