Giter VIP home page Giter VIP logo

Comments (3)

Ali-Tehrani avatar Ali-Tehrani commented on August 21, 2024

Thank you @marco-2023. This also affects ExpRTransform, and PowerRtransform and is related to the fix in issue #143. This is a feature rather than a bug.

The dilemma of setting the b-parameter in the way that fixes your problem is if the user wants to use the functions inverse, deriv or transform again with the same b-parameter. It is written in the code document 1, 2 that the b parameter is set from the first grid that it is used but isn't very clear that it is permanent

The solution to make it more clear for the users is to either:

  1. Require the user to define the b parameter in the initializer __init__ so that it is apparent. Currently, it is automatic.
  2. Write out a warning if the maximum of the grid being used is different from the b parameter. This adds an additional O(N) cost, but for radial grids N is small, so it's fine.

from grid.

marco-2023 avatar marco-2023 commented on August 21, 2024

Thank you very much @Ali-Tehrani for clearing my doubts. I will close this issue then (as it is not an issue at all).

from grid.

PaulWAyers avatar PaulWAyers commented on August 21, 2024

@marco-2023 and @Ali-Tehrani the main solution to this issue is, as Ali notes, just documentation/examples. I think option #2 is probably the way to go, and then clearify the documentation that the b parameter is permanent.

from grid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.