Comments (3)
Thank you @marco-2023. This also affects ExpRTransform
, and PowerRtransform
and is related to the fix in issue #143. This is a feature rather than a bug.
The dilemma of setting the b-parameter in the way that fixes your problem is if the user wants to use the functions inverse
, deriv
or transform
again with the same b
-parameter. It is written in the code document 1, 2 that the b parameter is set from the first grid that it is used but isn't very clear that it is permanent
The solution to make it more clear for the users is to either:
- Require the user to define the
b
parameter in the initializer__init__
so that it is apparent. Currently, it is automatic. - Write out a warning if the maximum of the grid being used is different from the
b
parameter. This adds an additional O(N) cost, but for radial grids N is small, so it's fine.
from grid.
Thank you very much @Ali-Tehrani for clearing my doubts. I will close this issue then (as it is not an issue at all).
from grid.
@marco-2023 and @Ali-Tehrani the main solution to this issue is, as Ali notes, just documentation/examples. I think option #2 is probably the way to go, and then clearify the documentation that the b
parameter is permanent.
from grid.
Related Issues (20)
- Document Negative Weights and other Angular Grid Peculiarities HOT 8
- Add test; Make sure moments behave correctly when origin is shifted.
- Poisson Solver initial value problem implementation is not robust. HOT 4
- ImportError: cannot import name 'path' from 'importlib_resources'
- Python 3.6 installation problems HOT 1
- Molecular Grid from Atomic Grids HOT 4
- Local Grid and Periodic Boundary Conditions examples
- Molecular dipole moment uses incorrect origin?
- Construct and export cube files HOT 3
- Fix `DeprecationWarning` and `PytestRemovedIn8Warning` HOT 1
- ODE didn't converge in bvp poisson solver
- Get Atomic Property HOT 1
- The grid logo is not showing on the website.
- Angular Grid Docstring Formula HOT 3
- Integration of the Sphere with Maximum Determinant Points HOT 1
- Lattice rules for (hyper)cubic grids
- Interpolation/differentiation on parallelepiped grids
- The url of grid logo is not linked correctly .
- Link Website's API to GitHub's Source Code HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grid.