Giter VIP home page Giter VIP logo

Comments (9)

krasnoukhov avatar krasnoukhov commented on July 30, 2024

Hey @noinnion, thanks for reporting. What do you mean by 2-way sync feature? And what if user has more than 1000 (all or even unread) items?

from api.

noinnion avatar noinnion commented on July 30, 2024

in gReader we use /stream/items/ids to synchronize unread items from server to client. i.e. items read on TheOldReader server will be synced back to gReader. If the limit is only 1000 items that are outside these 1000 items will no be recognize. gReader uses incremental synchronization so that only new items are downloaded.

Hope you can increase the limit to 10000 as before.

from api.

krasnoukhov avatar krasnoukhov commented on July 30, 2024

Ok, I see. So, if user has more than 10000 unread items gReader won't sync them all? (Assuming the limit is 10000)

from api.

noinnion avatar noinnion commented on July 30, 2024

10000 should be enough. Everything larger than 10000 could be ignored.
Hope you can fix it as soon as possible. The problem right now is that it breaks gReader functionalities.

from api.

krasnoukhov avatar krasnoukhov commented on July 30, 2024

I'll try to figure how we can fix this asap. In the meantime, is there any reason why gReader doesn't use continuation for any cases when not all data is fetched? I'm pretty sure there are people with 10000 or more items.

from api.

noinnion avatar noinnion commented on July 30, 2024

we use continuation to get more than 1k items. but more than 10k is too much for a reader. (/stream/items/ids does not support continuation) We also use nt/ot to optimize synchronization.

if ppl have more than 10k items in their inbox that means they are not using it for a while. All these items outside these 10k are not relevant anymore. Also using more than 10000 would slow down the app in term of performance.

from api.

noinnion avatar noinnion commented on July 30, 2024

@krasnoukhov I just see that there is a continuation in the response.
It could solve the issue but using it is not very convenient. Increasing limit to 10k is a lot of better.

Thanks

from api.

krasnoukhov avatar krasnoukhov commented on July 30, 2024

Ok, limit is 10000 for ids now, please see related note in readme.

from api.

noinnion avatar noinnion commented on July 30, 2024

great, thank you for the quick fix

from api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.