Giter VIP home page Giter VIP logo

Comments (5)

ragboyjr avatar ragboyjr commented on May 22, 2024

Ya, this is a good feature, you should submit a PR for this.

from plates.

reinink avatar reinink commented on May 22, 2024

The idea behind the default value for sections was really more intended for inline short hand, such as:

<title><?=$this->section('title', 'The default title')?></title>

For more complex defaults, I sort of feel like a simple if statement is a better approach, similar to what we have in the Plates documentation:

<html>
<head>
    <title><?=$this->e($title)?></title>
</head>
<body>

<img src="logo.png">

<div id="page">
    <?=$this->section('page')?>
</div>

<div id="sidebar">
    <?php if ($this->section('sidebar')): ?>
        <?=$this->section('sidebar')?>
    <?php else: ?>
        <?=$this->fetch('default-sidebar')?>
    <?php endif ?>
</div>

</body>
</html>

That avoids rendering the default-sidebar unless no sidebar section has been set.

from plates.

reinink avatar reinink commented on May 22, 2024

That being said, it would be interesting to make the section default also accept a template name, in addition to only a string. That default template would only be rendered in the event that no section was found.

But how do we identify that a default template was provided and not just some string to output? We could:

  1. Check to see if the string provided resolves to a template, and if it does render it.
    $this->section('sidebar', 'default-sidebar', ['some' => 'data']);
  2. Append a value to indicate that this is a template, not a string.
    $this->section('sidebar', 'template:default-sidebar', ['some' => 'data']);
  3. Assume this is a template if data is provided (meaning you need the 3rd param even if you don't have any data)
    // with data:
    $this->section('sidebar', 'default-sidebar', ['some' => 'data']);
    // without data:
    $this->section('sidebar', 'default-sidebar', []);

from plates.

velosipedist avatar velosipedist commented on May 22, 2024

@reinink in my experience i rarely had to specify just default string, maybe solution 3 is most useful with some fallback extension:

// default template
$this->section('sidebar', 'default-sidebar', ['some' => 'data']);
// default string
$this->section('sidebar')->or('No sidebar :(');

I think that is intuitive enough and makes unnecessary to specify empty data array.
Also or() can have alternative signature to pass also template name and params, so we can even leave strictly one param to section() call — ultimately transparent and intuitive.

// by prefix
$this->section('sidebar')->or('::template/name' /*, ['optional'=>'data']*/);
// separate method
$this->section('sidebar')->orTemplate('template/name' /*, ['optional'=>'data']*/);

from plates.

ragboyjr avatar ragboyjr commented on May 22, 2024

Closing in favor of #169. Will spend some time working on the syntax for this. It also relates to #48.

from plates.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.