Giter VIP home page Giter VIP logo

Comments (10)

thesilican avatar thesilican commented on June 2, 2024

Are you using Safari on iOS, iPadOS, or macOS? What Safari version are you using?

from duotrigordle.

Thesnake66six avatar Thesnake66six commented on June 2, 2024

iOS 15.4, not sure about safari version but the latest for that iOS version.

Also, I just tried again, and it didn’t kill safari, but made it unresponsive for about 25-30 seconds. I screen recorded it but am not sure how to attach it using the web version of GitHub

from duotrigordle.

bobpaul avatar bobpaul commented on June 2, 2024

I think you can just drag/drop files into the comment box

from duotrigordle.

thesilican avatar thesilican commented on June 2, 2024

Do you get the same behavior if you use Chrome? Also, which model iPhone are you using?

from duotrigordle.

DanReyLop avatar DanReyLop commented on June 2, 2024

Also, I just tried again, and it didn’t kill safari, but made it unresponsive for about 25-30 seconds.

I'm using a 2019 16" Macbook Pro (latest Monterrey and Safari versions), and I also noticed that the page becomes unresponsive when I type a correct word. In my case, it's just for about 1 second, but it's definitely noticeable. It doesn't bother me but it may make debugging easier than if it only happened on iPhones :)

from duotrigordle.

Thesnake66six avatar Thesnake66six commented on June 2, 2024

Hi! I’ve just given it another go and the length of freeze seems to improve based on the number of solved boards - Solving 10 boards makes it a lot shorter

from duotrigordle.

thesilican avatar thesilican commented on June 2, 2024

My suspicion is that this isn't a Safari specific issue, it's that the app itself is somewhat performance intensive to begin with, and Safari just has a slower renderer. I will investigate when there is time

from duotrigordle.

bexelbie avatar bexelbie commented on June 2, 2024

If it’s useful, on iOS 15.4.1 running on an iPhone 13 Pro the delay is several seconds (<4) and reduces as the solved woot count increases. IIRC, there is almost no delay in airplane mode.

from duotrigordle.

krevis avatar krevis commented on June 2, 2024

The bug depends on the "Hide completed boards" and "Fade out" settings.

With "Hide completed boards" turned on, and "Fade out" turned off, there's no bug, the response is instantaneous. With other combinations, it's slow.

Here's the Safari profiler showing a multi-second pause with "Hide completed boards" turned off. It's all attributed to a CSS transition on the filter property of div.board.complete.
Screen Shot 2022-06-26 at 12 53 59 PM

Sure enough, each completed board has an animated transition to put the dimming filter on it:

.game:not(.game.hide-completed-boards) .board.complete {
  filter: contrast(0.5) brightness(0.5);
  transition: filter 150ms ease-out;
}

I'll try tinkering with that.

(I'm guessing there is a more efficient way to get the dimming effect than applying contrast and brightness filters; a simple gray translucent overlay would likely be effective enough. I'm also seeing a lot of dark visual glitches around completed boards, when scrolling around on iPhone or iPad, and I'm suspicious that these filters are the cause.)

from duotrigordle.

krevis avatar krevis commented on June 2, 2024

FWIW, just taking out the transition is enough to fix it. The filter by itself seems to be OK.

With the transition: replacing the filter with opacity 0.1 still has the bug, but setting background-color does not (it animates immediately and smoothly). Mysterious.

from duotrigordle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.