Giter VIP home page Giter VIP logo

Comments (7)

recolic avatar recolic commented on May 17, 2024 1

This issue is still not fixed in version 0.6.2.

image

from simple-http-server.

gurry avatar gurry commented on May 17, 2024

A quick debugging session showed that we're setting the content length correctly for HEAD requests:

resp.headers.set(ContentLength(metadata.len()));

which is identical to how we set it for GET requests:

resp.headers.set(ContentLength(metadata.len()));

Yet it works for GET and doesn't work for HEAD. What gives?

I also saw in the debugger that the metadata field does contain the correct length read from the file system for HEAD.

from simple-http-server.

TheWaWaR avatar TheWaWaR commented on May 17, 2024

Seems hyper or iron reset the ContentLength

A PR is welcome! : )

from simple-http-server.

gurry avatar gurry commented on May 17, 2024

Thanks @TheWaWaR.

I agree with you. I should've ideally done the fix, but I'm in the middle of a lot of stuff right now. So will have to do this later (unless someone beats me to it).

from simple-http-server.

gurry avatar gurry commented on May 17, 2024

It's an Iron bug. I've filed an issue there: iron/iron#582

from simple-http-server.

sergeevabc avatar sergeevabc commented on May 17, 2024

Are you going to release a new Windows binary with this fix?

from simple-http-server.

gurry avatar gurry commented on May 17, 2024

Will have to move to the new version of Iron to get this fix released.

from simple-http-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.