Comments (3)
Hey @bazzadp, thanks for the report. I wouldn’t be surprised if the parser was overly strict in that respect, having had to fix issues with it failing to parse self-closing SVG tags (#4), or uppercase HTML tags.
If you’re keen to look into this I think the fix would likely be to allow whitespace for all of the cases in
Lines 693 to 699 in 35a1412
Looking at the potential implementation, there might be a fair bit of duplication, since parsing for all of those different types of tags is separated out.
In the meantime, it might help to set Prettier to htmlWhitespaceSensitivity: ignore
. I’d also happily accept a PR to document this issue on the website (perhaps a new "Known issues" page either at the end of the "Introduction" section, or under "References").
Can I ask what language or Prettier plugin you’re using for your templates? I think I ran into this issue before but didn’t really make much of it since Prettier doesn’t support the template syntax of Jinja / Django Templates I most commonly work with.
from curlylint.
Finally spending time to look into this further, the issue is here:
Line 450 in c144fc6
This assumes the tag name on closing tags is directly followed with >
. I think the fix could be as simple as:
-P.string("</").then(tag_name_parser).skip(P.string(">"))
+P.string("</").then(tag_name_parser).skip(whitespace + P.string(">"))
However I’m a bit hesitant to make parser changes like this until there is a better test suite in place. Any help towards this would be much appreciated!
from curlylint.
Upvote for this from me.
Is there a way to tell curly to ignore these types of errors in the meantime?
220:12 Parse error: expected one of '>', 'attribute', '{#', '{%', '{{' at 220:12 parse_error
from curlylint.
Related Issues (20)
- When using the curlylint linter in Django templates it generates a false positive parse error HOT 1
- Ability to do simple checks on template tag content HOT 3
- `pip install curlylint` does not work due to incompatability with click 8.1.0 HOT 1
- Support Alpine.js syntax HOT 1
- Parsing fails for {% comment %} including number within HTML tag
- parse error expectation wrong HOT 1
- TypeError: can only concatenate str (not "Parser") to str HOT 1
- Parser fails on comment containing HTML tag
- Invalid test usage in Jinja2 isn't caught by linter
- Crash when closing HTML tags inside Jinja2 if statements HOT 2
- Action Required: Fix Renovate Configuration
- Tests from sdist fail HOT 3
- Stumbles over… I don't know what ;) HOT 3
- image_alt rule fails to find missing alt tag inside django block HOT 1
- invalid parse error HOT 1
- Make it possible to skip/ignore rules/linting on specific lines HOT 5
- Support for self closing tags (HTML / XML) HOT 4
- Handling <!doctype html> HOT 1
- Exclude folders/files from linting HOT 1
- Dependency Dashboard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from curlylint.