Giter VIP home page Giter VIP logo

Comments (10)

thieman avatar thieman commented on June 16, 2024

@extrinsicmedia The Cron entry gets interpreted as a local time on the server running Dagobah. The frontend then takes the UTC representation of that time and shows it to you in your browser's timezone. My guess is that your server and your browser are about half a world away from each other. Am I close?

from dagobah.

extrinsicmedia avatar extrinsicmedia commented on June 16, 2024

@thieman I'm testing locally so they're both on the same machine.
Possible that the Cron entry is getting interpreted from UTC 0?

from dagobah.

thieman avatar thieman commented on June 16, 2024

Hmm, yeah maybe something is getting converted where it shouldn't. I testing servers running UTC, so it'd make sense if I missed something. Will check it out, thanks.

from dagobah.

thieman avatar thieman commented on June 16, 2024
  1. The server is asserting that the Cron time is based on UTC. This needs to instead use the server's local time.
  2. When the server passes datetimes to the frontend, they do not have TZ information. The frontend assumes that everything is in UTC. The backend should convert its datetimes to UTC before sending them to the frontend.
  3. I don't think the frontend ever sends datetimes to the backend (it only sends Cron strings), so we don't have to juggle authoritative timezones between the client and server. Hooray.

from dagobah.

thieman avatar thieman commented on June 16, 2024

I think I wrote a fix for this like two months ago. I'll actually get off my ass and try to merge it this weekend.

from dagobah.

gardinerd avatar gardinerd commented on June 16, 2024

I ran into this issue as well while running on a server set to EDT. Happy to help test this out further.

from dagobah.

thieman avatar thieman commented on June 16, 2024

@Creator11 This is my work-in-progress branch if you'd like to give it a go: https://github.com/thieman/dagobah/tree/tnt-fix-cron-format

Thanks for the assist!

from dagobah.

gardinerd avatar gardinerd commented on June 16, 2024

Thanks I'll give it a go through a QA regression.

from dagobah.

gardinerd avatar gardinerd commented on June 16, 2024

@thieman pull down the new branch and built. However after building and running the branch it appears you cannot create new jobs. Using the SQLiteImpl

from dagobah.

thieman avatar thieman commented on June 16, 2024

Well, that's certainly interesting. Will take another pass this weekend, thanks.

from dagobah.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.