UIImage extension clips image about fontawesome.swift HOT 4 CLOSED

I have noticed this behaviour as well, but I don't think that line is the cause of this issue. If you set the size as a square, the sides are still cut off, so min/max makes no difference in that case. I think it should still be min though, because it should be an icon that fits inside the given size. if you give a size of 100x10, you would still want to see the whole icon, and it should be size 10, shouldn't it? I don't believe that's the same issue though...

from fontawesome.swift.

Yup you're right. The way I get around that right now is looking up the ratio of the icon on fontawesome.io and setting the size of the image accordingly (i.e. if the icon isn't a square don't set the image to one). But this only works by changing max to min.

from fontawesome.swift.

On FontAwesome.io in their fixed width example, they have the width set as 1.28571429em which I assume is the maximum width:height ratio for their icons. When I get a chance in a few hours, I'll add this magic number into a pull request, along with your min/max fix.

from fontawesome.swift.

Fixed in #47.

from fontawesome.swift.