Hi, thanks for this library. I noticed that <code class="notranslate

Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-u

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

hey <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

thank you <a class="user-mention notranslate" data-hovercard-type="user" data-hovercar

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

allOf operator and ajv-keywords support about json-schema-to-ts HOT 8 CLOSED

thomasaribart commented on May 12, 2024

allOf operator and ajv-keywords support

from json-schema-to-ts.

Comments (8)

ThomasAribart commented on May 12, 2024 1

Thanks @svsool ! Gonna have a look at it 👀

from json-schema-to-ts.

ThomasAribart commented on May 12, 2024

@svsool Thanks for the heads up. JSON-schemas are extendable, so yes, FromSchema should accept custom properties.

Modifying this as we speak.

from json-schema-to-ts.

ThomasAribart commented on May 12, 2024

@svsool Should be solved in 2.5.5, can you confirm this ?

Solved by #85

from json-schema-to-ts.

svsool commented on May 12, 2024

it works, thank you!

from json-schema-to-ts.

svsool commented on May 12, 2024

hey @ThomasAribart, unfortunately seems to be broken with json-schema-to-ts 3.7.2, TypeScript 5, and JSONSchema7:

this is package.json:

{
  "name": "schema-repro",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "type": "module",
  "scripts": {
    "ts": "tsc --project ./tsconfig.json --noEmit"
  },
  "devDependencies": {
    "@tsconfig/esm": "^1.0.2",
    "@tsconfig/node18": "^1.0.1",
    "@tsconfig/strictest": "^2.0.0",
    "json-schema-to-ts": "2.5.2",
    "typescript": "^5.0.3"
  }
}

and types.ts:

import type { FromSchema } from 'json-schema-to-ts';

export const countryCode = {
    type: 'string',
    allOf: [
        {
            transform: ['trim'],
        },
        {
            minLength: 2,
            maxLength: 3,
        },
    ],
} as const;

export type CountryCode = FromSchema<typeof countryCode>;

tsconfig.json:

{
  "extends": ["@tsconfig/strictest/tsconfig.json", "@tsconfig/node18/tsconfig.json", "@tsconfig/esm/tsconfig.json"],
  "compilerOptions": {
    "typeRoots": ["node_modules/@types"],
    "outDir": "build",
    "baseUrl": "src",
    "sourceMap": true,
    "downlevelIteration": true,
    "resolveJsonModule": true,
    "exactOptionalPropertyTypes": false,
    "noImplicitReturns": false,
    "noPropertyAccessFromIndexSignature": false,
    "noUncheckedIndexedAccess": false,
    "noUnusedParameters": false,
    "checkJs": false,
  },
  "exclude": ["node_modules"]
}

run yarn ts to reproduce

from json-schema-to-ts.

ThomasAribart commented on May 12, 2024

@svsool Should work in 2.8.0 with the new ExtendedJSONSchema and FromExtendedSchema types:

type Extension = {
  transform: string[];
};

export const countryCode = {
  type: "string",
  allOf: [
    {
      transform: ["trim"],
    },
    {
      minLength: 2,
      maxLength: 3,
    },
  ],
} as const;

export type CountryCode = FromExtendedSchema<Extension, typeof countryCode>;
// => string