Comments (4)
nimeshsubramanianv2
commented on June 10, 2024
1
Thank you, I'll try and get you a PR soon. I just wanted to run it by you first before I went about implementing it.
from go-feature-flag.
thomaspoignant
commented on June 10, 2024
1
@nimeshsubramanianv2 It was a bit more work than I was expecting, but I have opened a PR #790.
If you want to have a look at the PR.
It will be released in the next version.
from go-feature-flag.
thomaspoignant
commented on June 10, 2024
@nimeshsubramanianv2 I agree with you that we don't want to log on those endpoints because it can be super noisy.
I think actually that it should be default behavior and only log if we are running the relay proxy in debug mode.
debug mode is when in the configuration of the relay proxy the field debug is set to true.
If you want to work on this feel free to open a PR, and please ping me (here or in slack) if you need any help.
From my first investigation we should look at the function ZapLoggerWithConfig that will allow us to configure a Skipper function.
from go-feature-flag.
thomaspoignant
commented on June 10, 2024
@nimeshsubramanianv2 will you work on it?
If not I can try to do it soon.
from go-feature-flag.
Related Issues (20)
- Change the writing file mechanism
- (bug) AwsConfig ignored as of s3Retrieverv2 refactoring HOT 3
- (change) Use slog in the go module HOT 2
- (feature) <PHP provider> HOT 1
- (feature) Add an option to not retrieve flag values on weekend or dev environment to reduce carbon footprint HOT 9
- 👀 Open pull request on open feature contrib repositories HOT 20
- (bug) OFREP error should contain flag key
- Did 1.26.0 release get re-tagged? HOT 2
- (bug) flaky test - Test_websocket_flag_change HOT 2
- Default value when there is no feature flags in the cache HOT 2
- K8S Relay proxy config templating
- (bug) [relay-proxy] Override configuration via env variables in `retrievers` does not work HOT 5
- (change) Allow templating in relaxyproxy.config helm chart values HOT 1
- (feature) Force call to the retrievers
- (feature) Integration with Datadog RUM
- (bug) targetingKey does not work in the query of targeting rule using OFREP HOT 6
- (doc) Describe evaluation context HOT 2
- (change) Propose updating the base image of relay proxy to Debian 12 (bookworm) HOT 2
- (feature) Github Retriever check rate limiting
- (change) Github retriever add Github response header in the error.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-feature-flag.