null parameter does not work as expected about fluentdom HOT 9 CLOSED

Why? If you need to remove the content you can send an empty string as value.

from fluentdom.

Why what? It's about making it compatible with jQuery API.
Consider the following example:

$dom->html($w)->attr('placeholser',$x)->$attr('maxlength',$y)->$att('title',$t); 

If any of $w,$t, .. variables is set to null the corresponding method will act as a getter, the chain will break and an exception will be thrown. This is not the case in jQuery api.

from fluentdom.

You can always cast the variables.
$dom->html((string)$w)->attr('placeholder',(string)$x)...

PHP functions usually make no difference between NULL and undefined. NULL is for optional parameters (type hints, but internal functions, too).

In your example you provide the arguments. See this example:

function dump() {
  var_dump(func_get_args());
}
dump($a, $b);

array(2) {
  [0]=>
  NULL
  [1]=>
  NULL
}

from fluentdom.

You can easily solve that fundamentally and there is no need to add a (string) everywhere.

function attr()
{
    if (count(func_get_args()) < 2) {
        return 'I am a getter!';
    };
    return 'I am a setter!!';
}

echo attr('type').PHP_EOL;
echo attr('type',null).PHP_EOL;
echo attr('type','foo');

I am a getter!
I am a setter!!
I am a setter!!

from fluentdom.

Yes, but even an undefined variable like in my example is treated as NULL. I will think about it, but I am a little afraid how much code (that uses FD) would break.

from fluentdom.

I don't know what you are trying to show by that example, how your example is related to this issue.. May you please provide an example of breaking code?

from fluentdom.

Some source that wraps or extends the current methods. It would expect the current behavior. If a method extends FluentDOM:attr() and calls the parent method expecting the current behavior it will break.

from fluentdom.

Variadics allow for a cleaner implementation of optional arguments (then func_get_args()) and even for generic wrapper functions:

function attr($name, ...$arguments) {
  var_dump($arguments);
}

function attributes($name, ...$arguments) {
  attr($name, ...$arguments);
}

attributes('one');
attributes('two', '21');

from fluentdom.

Well done. Thanks.

from fluentdom.