How to remove the buffer clearing behavior in SwRenderer::preRender about thorvg HOT 6 CLOSED

@FASTSHIFT Hello, ThorVG has actually been improved to meet your requirements.

Clear method in main:

In the official version clear buffer is always occurred in default but the behavior is not in the dev branch. clear is only occurred by a user call.

The thing is, this change has only been made in the main branch and hasn't been applied to the official release (i.e., 0.12.x) due to concerns about backward compatibility.

I'm not certain, but perhaps LVGL can manually cherry-pick this feature change to meet your demand? @kisvegabor

#1778
#1798

from thorvg.

Great news!

Actually we are still not sure how to track the changes of ThorVG. Right now we needed to add modifications for 3 issues:

1. This one
2. #1742
3. #1898

Only #1742 is not resolved yet. If it were updated, we could just copy paste the required folders to LVGL on ThorVG releases.

from thorvg.

In the official version clear buffer is always occurred in default but the behavior is not in the dev branch. clear is only occurred by a user call.

Thank you very much for your reply, the code from the development branch meets the needs perfectly!

The thing is, this change has only been made in the main branch and hasn't been applied to the official release (i.e., 0.12.x) due to concerns about backward compatibility.

Can we consider adding a parameter to control the rasterClear call in preRender in the official version? rasterClear will be called by default, allowing users to disable this behavior through parameters, so as to achieve forward compatibility.

from thorvg.

@hermet FYI, I just added the clear calls to Godot and tested both of today's Github tips, and everything looks good to me.

CI https://github.com/capnm/godot4/actions/runs/7659208546

from thorvg.

@capnm Ok, Thanks. Note that the clear call is necessary with thorvg/main, but if this clear call is introduced in the official Godot release with ThorVG (0.12.x), the clear will actually be performed twice. This might slightly reduce performance in SVG drawing. Probably, that will be good if it could apply the clear call patch only for the CI godot + thorvg/main test.

from thorvg.

... Probably, that will be good if it could apply the clear call patch only for the CI godot + thorvg/main test.

Yes, that's exactly what I try to do. It helps me to catch new issues in my projects that might occur later in the releases more quickly.

from thorvg.