Missing documentation about Vundle? about dotfiles HOT 10 CLOSED

It looks like this shell script is supposed to get run at some point during the git cloning or afterward?
https://github.com/thoughtbot/dotfiles/blob/master/hooks/post-up

from dotfiles.

Try running the rcup command with the -k option. There was a recently-fixed bug where after-hooks were not run by default which may be causing this issue.

from dotfiles.

Ok, should I send a PR for a change to the Readme? Also it's pretty obvious but might be worth documenting that one should cd into ~/dotfiles prior to running brew bundle?

from dotfiles.

Should I send a PR for a change to the Readme?

When did you install rcm? If the current version doesn't contain the hook-fix, I'd rather see that addressed before adding a workaround to the README. /cc @mike-burns

Also it's pretty obvious but might be worth documenting that one should cd into ~/dotfiles prior to running brew bundle?

If you find anything unclear, a PR is always welcome.

from dotfiles.

I installed rcm on one system yesterday and another system this morning. I had the same result both times (without passign the -k flag). I was just suggesting a PR to document passing the -k flag until such time as it is no longer required. I'll send a PR and we can go from there.

from dotfiles.

@sohara which version of rcm are you using?

rcup -V

from dotfiles.

@mike-burns I'm using 1.1.0. I installed using homebrew.

from dotfiles.

Just installed rcup 1.1.0 and has the same issue of vundler not being installed. Running rcup with the -k flag solved the problem i.e:

rcup -k -d dotfiles -x README.md -x LICENSE

Looking through man rcup the -k flag runs pre and post hooks. Not sure why the post hook isn't getting run without the flag.

from dotfiles.

There was a bug in rcm 1.1 that hooks were not run by default (as was intended). rcm 1.2 has the fix and has been released.

from dotfiles.

Awesome. Thanks!

from dotfiles.