Comments (7)
t3hpr1m3
commented on August 25, 2024
https://github.com/t3hpr1m3/shoulda-matchers/tree/generate_message
2 commits:
t3hpr1m3@1fd43bc
t3hpr1m3@7b12a7e
No tests were added/modified because the existing specs added by clemenshelm@662b674cf4e67c0af428c694a46e4a9d2060cb7f still cover these changes.
from shoulda-matchers.
pi3r
commented on August 25, 2024
👍 This is totally usefull, since 3.2.1 changed the way error messages are created.
from shoulda-matchers.
pi3r
commented on August 25, 2024
@t3hpr1m3: you should do a pull request and not only mention your code.
@mike-burns: It's a real priority because shoulda-matchers do not work with rails3.2.1 due to wrong error messages.
from shoulda-matchers.
t3hpr1m3
commented on August 25, 2024
@pi3r According to https://github.com/thoughtbot/shoulda-matchers/blob/master/CONTRIBUTION_GUIDELINES.rdoc, pull requests are frowned upon.
from shoulda-matchers.
pi3r
commented on August 25, 2024
@t3hpr1m3 Oups, you are right. My bad :)
from shoulda-matchers.
mike-burns
commented on August 25, 2024
That's way out of date; thanks for catching that!
@pi3r and @t3hpr1m3 Pull requests are welcome!
from shoulda-matchers.
gabebw
commented on August 25, 2024
Looks like the discussion has moved to #55 and #56. Closing.
from shoulda-matchers.
Related Issues (20)
- Shoulda Matchers ActiveRecord Validate Uniqueness HOT 1
- validation_inclusion_of is returning ArgumentError HOT 1
- Minitest: is there a recommended way to use `shoulda-matchers` without using `shoulda-context` ? HOT 2
- Uniqueness matcher does not account for custom error messages HOT 2
- wrong constant name dummy value on rails 7 HOT 5
- rspec spec/unit fails with ruby 3.3.0dev
- Wrong error with matcher HOT 16
- Cannot validate numericality with dynamic values HOT 2
- Ruby-tests-explorer and shoulda integration HOT 1
- Add `query_constraints` qualifier to the association matcher.
- Numericality matcher not working as expected on 6.0.0 HOT 3
- Should implicit default values have valid expectations? HOT 4
- RangeError: cannot get the first element of beginless range
- polymorph uniq check fails with 6.2 HOT 7
- What Pieces of ActiveModel/ActiveRecord need to be present for shoulda to appear? HOT 2
- validate_presence_of tries to set the value for a read_only attribute HOT 3
- undefined method `validatate_presence_of' for #<RSpec::ExampleGroups::Organization::Validations> HOT 1
- Record uniqueness matcher fails with STI when type column is enum HOT 4
- counter_cache validation fails with Rails 7.2.beta HOT 2
- "Class" loaded more than once?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shoulda-matchers.