Giter VIP home page Giter VIP logo

Comments (3)

thrasher- avatar thrasher- commented on July 20, 2024

By default Go will only unmarshall JSON data which it knows about (unless just put into an interface{}) so any extra fields added will be ignored with no failure or error by design. Support specifically has to be added for it. Out of curiosity, are seperators sent in the extra data for currency pairs?

from gocryptotrader.

gloriousCode avatar gloriousCode commented on July 20, 2024

Yeah cool. Those fields are for me to easily handle things in the front-end. I strip any known seperators to be able to compare enabled currencies.
Good to know that the extra JSON isn't considered. GCT server doesn't need to care about it.

from gocryptotrader.

gloriousCode avatar gloriousCode commented on July 20, 2024

SetConfig cannot save if there are any warnings. I think that is fine, however, the reason for the warning I think should be removed.
After looking at WS response I got the following:
{"event":"SaveConfig","data":"OK","error":"WARNING -- SMS Support disabled due to default or empty Username/Password values."}

I feel like this should be removed. If a user runs GCT for the first time using front end, they will be unable to save until they modify the SMS details even if they do not want to change/use SMS settings. So a user will have to put gibberish into SMS settings to get past this warning.

This also applies to enabled contacts. These warnings should only come up if SMS support is enabled:
image

On the upside, I now display any errors to the user:
image

from gocryptotrader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.