Comments (17)
Hey @kempeng, yeah this is definitely something which we plan to address. So far our focus has been using the default variable types supplied with the Golang standard library but will eventually use either the Decimal package or use our own implementation.
from gocryptotrader.
I could do some work using Decimal if you want?
from gocryptotrader.
That would be awesome if you could! Thanks in advance :)
from gocryptotrader.
@kempeng I'd like to work on this one, Did you make any progress?
from gocryptotrader.
starting to make some progress. Investigated the approach first. Propose to use shopsping's decimal package. Will implement it in a forked version
from gocryptotrader.
@SamyGhannad , thank you for offering your help. I have forked the full source to kempeng/gocryptotrader, and now have a version in which I converted most of the float64's into decimal.Decimal's which compiles main.go.
I would appreciate it you can help me test this version and help me finish it further.
from gocryptotrader.
@thrasher-, if you have a moment, please take a look at my conversion of float64’s to decimals. I would be interested in your view how to integrate this back in the master code at some point?
from gocryptotrader.
Great work @kempeng! Will check out your branch and test it. Merging it will be straight forward to master as it will be just a matter of updating the dependencies and imports. I would also add a script to travis which checks to see if any submitted PR's contain float64's moving forward and complaining if it finds them.
from gocryptotrader.
hi @thrasher-, perhaps we can review what I have done & choices I made (not ALL float64's are converted) offline. Also, I only touch the core libraries, not for example the web service javascript codes. Not sure if I missed large chunks of code by just focussing on compiling main.go ?
from gocryptotrader.
@kempeng LGTM well done on the conversion!
from gocryptotrader.
what is the best way to get my forked version back into the master?
from gocryptotrader.
@kempeng rebase and open a PR on the branch that has these updates then we can merge it ourselves if its too complicated
from gocryptotrader.
@shazbert, thanks for the offer to help: I will need some help to do this. What is the first step I need to take?
from gocryptotrader.
@kempeng Are you on our Slack it will be easier to talk there, if so what is your username so I can PM you?
from gocryptotrader.
Yes, username Geert
from gocryptotrader.
What's the state on this? @kempeng, would you create a pull request?
from gocryptotrader.
Will create a PR for this shortly
from gocryptotrader.
Related Issues (20)
- Excuse me, are there some examples that can teach me how to use gocryptotrader to write a strategy in golang? HOT 1
- The startTime and endTime must be millisecond on Binance query deposit list. HOT 1
- could not find a copy of typescript to link HOT 1
- Binance websocket example
- Bug in Syncmanger does not allow for tickersync only. HOT 1
- any plan to support mexc? HOT 2
- Plase Help Me ... HOT 1
- Dispatcher tries to return used channels that are `<-chan interface{}` as `chan interface` and fails
- Buy/Sell/Ask/Bid actions do not have an expected outcome
- Bitstamp: depreciated balances *_usd _ fee
- Bitfinex: WS cancel stuck waiting for confirmation HOT 1
- Bitfinex: Switch WS type assertions
- pls add support commex.com HOT 3
- Request for supporting Upbit
- When set kline.interval to OneMonth, AddPaddings error
- database reconnection
- Error: ITBIT: pair config format is nil HOT 3
- Change leverage for Binance margin asset
- Bug in datahistorymanager HOT 4
- Bug in gateio_wrapper.go , it should be 'y' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gocryptotrader.