Giter VIP home page Giter VIP logo

Comments (7)

vutran avatar vutran commented on September 13, 2024 1

Maybe we can do without minimist or a 3rd party package since you have no dependencies right now which is awesome. Perhaps a standalone glamor-cli module would make sense as to keep the size of this repo down and just expose an extract API.

For my usage, I'm currently only using it primarily to compose styles on this app to allow composing with theme modules. Not using the css prop shim though. Haven't really taken a full look at the spec yet since I'm still reading through your code.

from glamor.

vutran avatar vutran commented on September 13, 2024

Hi @threepointone, first I'd like to thank you for creating a great framework. I began using this in my most recent app and am loving so far. I'm interested in helping contributing to this project and want to see if this feature is available for the taking and if you currently have a preference for which CLI toolkit you want to use?

from glamor.

threepointone avatar threepointone commented on September 13, 2024

Hi, thanks!

  • I like minimist
  • I have some preliminary work in src/extract.js
  • I also want to support streaming in source/streaming out css, and also outputting a json dump of html/css/ids
  • A complicated part is that src/app.js might be written in babel/jsx/flow/etc, so unsure on a clean way of dealing with that

from glamor.

threepointone avatar threepointone commented on September 13, 2024

Can you give me more feedback on your usage? Do you use the css prop shim? What is your usecase? Anything I can make better? Please, and thank you!

from glamor.

threepointone avatar threepointone commented on September 13, 2024

minimist is small enough that I think it'll be worth the cost.
dext looks neat! you wouldn't need the cli there though, unless you want to pregenerate styles/ids for fast startup?

from glamor.

thetrompf avatar thetrompf commented on September 13, 2024

I agree with @vutran it is cool that you don't have any dependencies right now, and I think for now it would be okay to pull in minimist as dependency until glamor gains more maturity and then later on, when the project is more stable, it could be nice to split the cli part in an independant package, but I believe right now it would be a pain to maintain.

from glamor.

threepointone avatar threepointone commented on September 13, 2024

closing this for now, will open if anyone has anything to show and tell :)

from glamor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.