Default rule when using IdentityId about throttlingtroll HOT 4 CLOSED

Hi @almightydegu , an IdentityId is a no-op without an IdentityIdExtractor (sorry if it is not clear from the documentation). That might be the reason of what you're observing.

Can you show your IdentityIdExtractor's code?

from throttlingtroll.

Thank you for the reply @scale-tone.

Below is the full object I'm using:

app.UseThrottlingTroll(options =>
{
    options.IdentityIdExtractor = request =>
    {
        return ((IIncomingHttpRequestProxy)request).Request.RouteValues["testId"]?.ToString();
    };

    options.Config = new ThrottlingTrollConfig
    {
        Rules = new[]
        {
            new ThrottlingTrollRule
            {
                UriPattern = "test$",
                IdentityId = "f411b023-dfb0-4756-9319-7bc24d11a682",
                LimitMethod = new FixedWindowRateLimitMethod
                {
                    IntervalInSeconds = 1000,
                    PermitLimit = 10
                }
            },
            new ThrottlingTrollRule
            {
                UriPattern = "test$",
                IdentityId = "758a3ff4-0655-4183-9406-20fbc8cb1bcc",
                LimitMethod = new FixedWindowRateLimitMethod
                {
                    IntervalInSeconds = 1000,
                    PermitLimit = 30
                }
            },
            new ThrottlingTrollRule
            {
                UriPattern = "test$",        
                LimitMethod = new FixedWindowRateLimitMethod
                {
                    IntervalInSeconds = 1000,
                    PermitLimit = 1
                }
            }
        }
    };
});

If I remove the third rule and just use the two rules that have the IdentityId set, then it works as expected, but I want to have a default option to the set up I want

from throttlingtroll.

Then I suggest you return some my-default-identity-id constant from your IdentityIdExtractor, when a request falls into this "default" category. And then have a separate ThrottlingTrollRule with IdentityId="my-default-identity-id".
That will not only work, but will also look explicit - leaves no doubt about how your system behaves.

Also remember, that ThrottlingTrollRule.IdentityId field is optional - when this value is omitted and IdentityIdExtractor is present, then all individual identities will get their separate counters automatically.

from throttlingtroll.

Doing that would mean all other requests would not be treated independently, which is what I was hoping for. I will need to create a rule for each of the IDs as a workaround. I mainly wanted this as a catch-all is a new ID is passed in without a rule and make the rules config cleaner to work with, but I can work around it

from throttlingtroll.