Giter VIP home page Giter VIP logo

Comments (5)

ilkkapeltola avatar ilkkapeltola commented on June 14, 2024

Right, yeah. I'm exceptionally poor with these kind of things, but I'll figure it out!

from thumbmarkjs.

ilkkapeltola avatar ilkkapeltola commented on June 14, 2024

Could you @le0pard check if what I did now works for you? I've published multiple formats with rollup:
IIFE (for browser): https://cdn.jsdelivr.net/npm/@thumbmarkjs/thumbmarkjs/dist/thumbmark.iife.js
UMD: https://cdn.jsdelivr.net/npm/@thumbmarkjs/thumbmarkjs/dist/thumbmark.umd.js
CommonJS: https://cdn.jsdelivr.net/npm/@thumbmarkjs/thumbmarkjs/dist/thumbmark.cjs.js
ESM: https://cdn.jsdelivr.net/npm/@thumbmarkjs/thumbmarkjs/dist/thumbmark.esm.js
AMD: https://cdn.jsdelivr.net/npm/@thumbmarkjs/thumbmarkjs/dist/thumbmark.amd.js

from thumbmarkjs.

le0pard avatar le0pard commented on June 14, 2024

Thanks, @ilkkapeltola

I will check in several hours, when will reach computer.

About formats - you just need esm, cjs and umd.

umd – Universal Module Definition, works as amd, cjs and iife all in one

So umd cover amd and iife.

Also will be good to add exports section in package.json : https://github.com/le0pard/re2js/blob/6fe44bd68f101d6993de9a60eb220ae04f334fbd/package.json#L26

BTW, unpkg key in package.json can be used for umd package : https://github.com/le0pard/re2js/blob/6fe44bd68f101d6993de9a60eb220ae04f334fbd/package.json#L25

from thumbmarkjs.

ilkkapeltola avatar ilkkapeltola commented on June 14, 2024

Thanks for the tips. Yeah, I was wondering if it's better to just provide umd and not the iife and amd separately at all. It doesn't seem to add too many bytes. Maybe for simplicity I'll do it that way. I'll look into the exports and unpkg too in a moment.

from thumbmarkjs.

le0pard avatar le0pard commented on June 14, 2024

Checked. ESM and CJS version works without issues:

const { getFingerprint } = require('@thumbmarkjs/thumbmarkjs');

(async () => {
  const data = await getFingerprint();
  console.log(data);
})()

and

import { getFingerprint } from '@thumbmarkjs/thumbmarkjs';

(async () => {
  const data = await getFingerprint();
  console.log(data);
})()

both output 12arglk, so it works. Big thanks!

from thumbmarkjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.