@request not getting set properly about jsonapi-utils HOT 8 CLOSED

@tiagopog and here's another breaking commit:

cerebris/jsonapi-resources@f8dcf85

You need to change JSONAPI::Request to JSONAPI::RequestParser.

from jsonapi-utils.

@tiagopog Shouldn't jsonapi-utils master have jsonapi-resources master as a dep though?

from jsonapi-utils.

@tiagopog FYI

from jsonapi-utils.

Weird, since the @request instance variable is set up before the action gets executed. I'll take a look on this later today. Thanks, @mecampbellsoup!

from jsonapi-utils.

@tiagopog it's a Rails 5 ApplicationController thing:

[1] pry(JSONAPI::Utils)> base
=> Api::V1::BaseController
[2] pry(JSONAPI::Utils)> base.respond_to? :helper_method
=> false
[3] pry(JSONAPI::Utils)> base.superclass
=> ApplicationController
[4] pry(JSONAPI::Utils)> base.superclass.respond_to? :helper_method
=> false
[5] pry(JSONAPI::Utils)> ActionController::Base.respond_to? :helper_method
=> true

from jsonapi-utils.

This bug ^^ is happening in our codebase because we track master of jsonapi-resources gem.

from jsonapi-utils.

@tiagopog further, I think that helper_method is only used by non-API Rails apps. We are using rails-api, makes sense we don't have helper_method exposed in our controllers as such.

from jsonapi-utils.

Since Rails 5 and JR's master are not supported by JU, this issue will be closed and a branch will be created for future support to their breaking changes.

from jsonapi-utils.