Support for page_count in response meta field about jsonapi-utils HOT 8 CLOSED

@tiagopog Would you need help merging the associated PR at all?

from jsonapi-utils.

Howdy, @ychaker!

Good catch! I would bring that simple feature to the gem but I'm totally out of time lately. Can you provide a PR with that implementation + specs?

Cheers!

from jsonapi-utils.

@tiagopog should I match what jsonapi-resources does, ie support the same configurations and make the implementation copy theirs, or would my simple hack suffice?

and are you aware of any other potential parts of the code that would need to be update accordingly?

from jsonapi-utils.

I see no problem on implementing this simpler version now. So you can stick with your hack since it achieves the expected results (specs will ensure that).

Implementing this page count on the formatter level, as you proposed on your hack, will spread the feature across the renders, so that the collection rendering should display it out of the box.

from jsonapi-utils.

@ychaker, are you still considering to implement this feature?

from jsonapi-utils.

hi @tiagopog I was on vacation last week.
I might take a stab at it later this week if you're still interested and haven't already done so yourself.

from jsonapi-utils.

I'm interested for sure :-)

from jsonapi-utils.

Closed by #87

from jsonapi-utils.