Giter VIP home page Giter VIP logo

Comments (6)

ethanopp avatar ethanopp commented on May 26, 2024 2

Thanks @mtik00! Got it working with the following (didn't need the =True portion):

  fitly:
    build:
      context: ./dockercontrol-master
      dockerfile: fitly-dockerfile
    container_name: fitly
    restart: always
    depends_on:
      - mariadb
      - letsencrypt
    ports:
      - "8050:80"
    environment:
      - MODULE_NAME=index
      - VARIABLE_NAME=app
      - TZ=America/New_York
      - GUNICORN_CMD_ARGS='--preload'
      - PUID=1001
      - PGID=100
    volumes:
      - /share/CACHEDEV2_DATA/Container/Fitly/config.ini:/app/config.ini
      - /share/CACHEDEV2_DATA/Container/Fitly/log.log:/app/log.log
      - /share/CACHEDEV2_DATA/Container/LetsEncrypt/keys:/app/keys

from meinheld-gunicorn-flask-docker.

mtik00 avatar mtik00 commented on May 26, 2024

Did you actually use preload=True in your config file? That would not be correct. The config file setting is named preload_app.

I'd give it another try with preload_app=True in the config file if so.

from meinheld-gunicorn-flask-docker.

ethanopp avatar ethanopp commented on May 26, 2024

@mtik00 updated to the following, still duplicating the cron job 'start':

  fitly:
    build:
      context: ./dockercontrol-master
      dockerfile: fitly-dockerfile
    container_name: fitly
    restart: always
    depends_on:
      - mariadb
      - letsencrypt
    ports:
      - "8050:80"
    environment:
      - MODULE_NAME=index
      - VARIABLE_NAME=app
      - PRELOAD_APP=True
      - TZ=America/New_York
      - PUID=1001
      - PGID=100
    volumes:
      - /share/CACHEDEV2_DATA/Container/Fitly/config.ini:/app/config.ini
      - /share/CACHEDEV2_DATA/Container/Fitly/log.log:/app/log.log
      - /share/CACHEDEV2_DATA/Container/LetsEncrypt/keys:/app/keys

Is this where you were referring to update it?

Update I manually added preload_app=True to gunicorn_conf.py and it seems to be working... Is there a way to automatically do this though (env variable?) so every time the image is refreshed it gets set appropriately?

from meinheld-gunicorn-flask-docker.

ethanopp avatar ethanopp commented on May 26, 2024

Alright I got this working with the following docker-compose. I went into the image and copy and pasted the gunicorn_conf.py code into a mounted file (named gunicorn_conf.py) and added the preload_app=True to that mounted file.

Then in the compose volumes I am overwriting the default images gunicorn_conf.py with the mounted version... The only issue I could foresee here is that if there is something in the images default gunicorn_conf.py that gets updated, it won't automatically get pulled through...

@mtik00 thanks for the tip with preload_app=True, you see any issues with this approach?

  fitly:
    build:
      context: ./dockercontrol-master
      dockerfile: fitly-dockerfile
    container_name: fitly
    restart: always
    depends_on:
      - mariadb
      - letsencrypt
    ports:
      - "8050:80"
    environment:
      - MODULE_NAME=index
      - VARIABLE_NAME=app
      - TZ=America/New_York
      - PUID=1001
      - PGID=100
    volumes:
      - /share/CACHEDEV2_DATA/Container/Fitly/gunicorn_conf.py:/gunicorn_conf.py
      - /share/CACHEDEV2_DATA/Container/Fitly/config.ini:/app/config.ini
      - /share/CACHEDEV2_DATA/Container/Fitly/log.log:/app/log.log
      - /share/CACHEDEV2_DATA/Container/LetsEncrypt/keys:/app/keys

from meinheld-gunicorn-flask-docker.

mtik00 avatar mtik00 commented on May 26, 2024

Looks fine to me (although I'm still learning 😉).

Maybe you can define GUNICORN_CMD_ARGS='--preload=True' env var instead of using the config file? 🤷‍♂️

The documentation for gunicorn isn't super clear on what variables get evaluated when.
http://docs.gunicorn.org/en/stable/settings.html#settings

You don't have to overwrite the default gunicorn config, but the result will be the same either way.

https://github.com/tiangolo/meinheld-gunicorn-flask-docker/blob/master/README.md#gunicorn_conf

I'd probably just copy it to /app/gunicorn_conf.py, but again, it will be doing the same thing: fully overwriting the default one.

from meinheld-gunicorn-flask-docker.

tiangolo avatar tiangolo commented on May 26, 2024

Thanks for the help here @mtik00 ! 👏 🙇

Thanks for reporting back and closing the issue @ethanopp 👍

from meinheld-gunicorn-flask-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.