Comments (2)
Hi Anthony,
As a rule-of-thumb; If a function returns an error, then handle the error. But there are times when I don't check an error, and it's usually one of two reasons:
- The function can't return an error, even though the function signature has a return value.
- Failure is optional and sometimes OK, and I often don't care what the error message is.
I'll explain the reason for each of lines you provided:
- https://github.com/muyiwaolurin/buntdb/blob/master/buntdb.go#L349
Thedb.Update()
call occurs in a background routine and runs once every second untildb.Close()
is called. Even ifdb.Update()
fails, I still want the routine to continue. An error has no relevance to the decision to stop the background routine. I may want to add logging methods in the future, at which point the error would be useful to write to the logger. - https://github.com/muyiwaolurin/buntdb/blob/master/buntdb.go#L83
The error returned from thedb.file.Close()
call is secondary to the error that was returned bydb.load()
. I wanted the caller ofdb.Open()
to know why the loading the file database file failed. - https://github.com/muyiwaolurin/buntdb/blob/master/buntdb.go#L1261
The type ofb
is abytes.Buffer
, andbytes.Buffer.WriteString
cannot return an error. Under the rare occasion thatb.WriteString
fails, which can only happen when the application runs out of memory, the function panics and the entire application fails.
This goes for the bufio.Writer.Write()
calls too. I ignore all of the errors because an error under-the-hood is likely an out-of-memory situation and will panic the system. The only error I care about is whether or not the data was written to disk. https://github.com/muyiwaolurin/buntdb/blob/master/buntdb.go#L447
I try to handle as many errors as possible, but the truth is some of them just don't matter. I would rather not waste any CPU cycles on those.
I hope this information helps and good luck.
from buntdb.
Thats awesome! Thanks Josh.
from buntdb.
Related Issues (20)
- Python bindings
- Enhancement: add new method GetWithTTL to return value together with TTL
- What happens if two funcs write to the db at the exact same time? HOT 1
- Get size of db on disk
- Does the data.db file support rewrite like redis AOF? HOT 2
- Dependencies update due?
- Feature Request: Delete inside iterator
- Question: cost/benefit of supporting generic types; and persisting secondary indexes
- Is it necessary to (defer) db.Close()?
- Expiry works only during runtime and is lost on shrink HOT 6
- index, or getting with different keys doesn't work HOT 1
- tx.Ascend doesn't work correctly HOT 1
- Does buntdb needs Go 1.18+ due to btree dependency? HOT 1
- Question: What is the format of .db file? HOT 1
- I wonder if we can find closest lat long for a given latlon from spatial index using nearby
- [Feature Request] Is there a way to limit memroy usage?
- Is there any plan to support index on MessagePack? HOT 1
- How to renew the ttl?
- Question: Is buntdb goroutine-safe? HOT 1
- Will "group by" be supported in this lib?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buntdb.