Giter VIP home page Giter VIP logo

Comments (3)

rene-dekker avatar rene-dekker commented on August 11, 2024 1

Thank you for raising this issue and for helping with a solution. I did some delving into the history of this repo. From what I understand:
This commit was present in 2019: https://github.com/tigera/operator/blame/eda3df71a96ec8d4aab6665feddfb41a8dc8a1c7/pkg/render/node.go#L482
At the time, this was the only reference to FELIX_HEALTHPORT in the code base. I think later refactors caused a possibility for a duplicate.

The core_controller is already setting the port for openshift. And in the current code base FELIX_HEALTHPORT is already set to the port in the configuration. Therefore, I believe a simpler fix could solve this installation issue: #2795

from operator.

dzacball avatar dzacball commented on August 11, 2024 1

Very nice, thanks a lot for spending time with this and providing a quick fix!

from operator.

dzacball avatar dzacball commented on August 11, 2024

I created a PR with a possible fix for this at #2785.

from operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.