Prometheus metrics for Typha - Currently hard coded about operator HOT 5 CLOSED

@zeysh When the operator next reconciles it would remove those (change the deployment back to what it expects), so I would expect your changes to get reverted at some point.

from operator.

We do want to add configuration for Typha prometheus.
The two options would be:

• Add a TyphaMetricsPort to the Installation CRD (we already have NodeMetricsPort)
• I think the preference would be to add a TyphaConfiguration CR (which doesn't exist yet) and then add configuration there, that would require a bit more work to add the new CR.

from operator.

I think the preference would be to add a TyphaConfiguration CR

TBH, that would be my preference, as it stays in keeping with the CR for FelixConfiguration (and would then allow config for other than the metrics port). At least I haven't missed anything obvious, I'll have a look at what's required and go from there.

from operator.

@cyclops8456 the workaround I use:

patch the calico-system/calico-typha deployment and add

- name: TYPHA_PROMETHEUSMETRICSENABLED
  value: "true"
- name: TYPHA_PROMETHEUSMETRICSPORT
  value: "9093"

to the env section for typha container.

from operator.

This is available now in the Installation CR as "TyphaMetricsPort" https://docs.projectcalico.org/reference/installation/api#operator.tigera.io/v1.InstallationSpec
Please comment if this does not meet your needs and I can re-open this.

from operator.