Giter VIP home page Giter VIP logo

Comments (3)

ybiquitous avatar ybiquitous commented on June 18, 2024 1

I appreciate your kindness! 😊
When I try the latest revision (ac10d1c) on the PoC PR, it works very well!
(just updating Ougai gem)

https://github.com/ybiquitous/ougai-rails-example/pull/1/commits/baf835b8e488f5ff2bd8ecd262fad811573a98d3

Console output

image

File output

image

from ougai.

ybiquitous avatar ybiquitous commented on June 18, 2024

I think it's a cause that ActiveSupport::Logger.broadcast is used automatically within Rails. By this, multiple loggers are called.

https://github.com/rails/rails/blob/530f7805ed5790af1d472a041bc74089dc183f47/activerecord/lib/active_record/railtie.rb#L60-L61

And, Ougai::Formatters::Readable modifies data argument (deteting :msg entry from data Hash), so I'm wondering that a next logger would receive a data without :msg. 🤔

msg = data.delete(:msg)

from ougai.

tilfin avatar tilfin commented on June 18, 2024

First, please use Ougai::Logger.broadcast instead of ActiveSupport::Logger.broadcast.
The following code prevents the railtie.rb#L60-L61 codes.

  # Logging
  config.logger = YourApp::Logger.new(STDOUT)
  file_logger = YourApp::Logger.new(config.paths["log"].first)
  config.logger.extend Ougai::Logger.broadcast(file_logger)

Second, I found that Ougai::Logger.broadcast currently has the bug if logging method is called with block and Readable formatter has another one too, so I fix it by #92 .

from ougai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.