Giter VIP home page Giter VIP logo

Comments (10)

timcassell avatar timcassell commented on June 16, 2024

That's strange. That line is

InternalHelper.PromiseBehaviour.Instance._updateProcessor.WaitFor(ref copy);

Which tells me PromiseBehaviour.Instance is null. That's only nulled out in OnApplicationQuit. I wouldn't expect other async code to continue running after that, but apparently it does.
I only started nulling it for AppDomain reload disabled support (#204). I wonder if there's a way I can keep that alive while still supporting AppDomain reload disabled.

from protopromise.

drew-512 avatar drew-512 commented on June 16, 2024

Another data point: times when the exception doesn't occur, it can take a suspiciously long time for all the images to load...no activity then boom they come in (if they come in). This seems consistent with they are queued under the hood, I exit play mode after seeing no activity for several seconds, and there's the OnApplicationQuit

from protopromise.

drew-512 avatar drew-512 commented on June 16, 2024

It get's weirder -- I'm watching net activity on my machine and it stays pegged up, which I can only presume the image(s) are continuing to fetch. This occurs 14 images in to a 20 URL queue. Confirmed that the activity is this issue since it goes away when I exit Unity.

from protopromise.

timcassell avatar timcassell commented on June 16, 2024

Confirmed that the activity is this issue since it goes away when I exit Unity.

Does it behave correctly if you enable AppDomain reload?

from protopromise.

drew-512 avatar drew-512 commented on June 16, 2024

Same behavior if regardless if all 3 checked or not. Restarted Unity a couple times over this and encountered this with all three unchecked.

from protopromise.

drew-512 avatar drew-512 commented on June 16, 2024

Argh, looks it's on me! Had a bug causing reloads to keep going. Sorry brother!

from protopromise.

drew-512 avatar drew-512 commented on June 16, 2024

Should I just use the latest from main? Seeing commits there and happy to help with testing, just want to understand what will be most helpful to you.

from protopromise.

timcassell avatar timcassell commented on June 16, 2024

fix-nullref-onapplicationquit branch

from protopromise.

drew-512 avatar drew-512 commented on June 16, 2024

LGTM.

I reintroduced that bug that was causing a non-stop flood of image load reqs and no exceptions thrown on stopping the player.

from protopromise.

timcassell avatar timcassell commented on June 16, 2024

@drew-512 Thanks!

from protopromise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.