Comments (10)
That's strange. That line is
InternalHelper.PromiseBehaviour.Instance._updateProcessor.WaitFor(ref copy);
Which tells me PromiseBehaviour.Instance
is null. That's only nulled out in OnApplicationQuit
. I wouldn't expect other async code to continue running after that, but apparently it does.
I only started nulling it for AppDomain reload disabled support (#204). I wonder if there's a way I can keep that alive while still supporting AppDomain reload disabled.
from protopromise.
Another data point: times when the exception doesn't occur, it can take a suspiciously long time for all the images to load...no activity then boom they come in (if they come in). This seems consistent with they are queued under the hood, I exit play mode after seeing no activity for several seconds, and there's the OnApplicationQuit
from protopromise.
It get's weirder -- I'm watching net activity on my machine and it stays pegged up, which I can only presume the image(s) are continuing to fetch. This occurs 14 images in to a 20 URL queue. Confirmed that the activity is this issue since it goes away when I exit Unity.
from protopromise.
Confirmed that the activity is this issue since it goes away when I exit Unity.
Does it behave correctly if you enable AppDomain reload?
from protopromise.
Same behavior if regardless if all 3 checked or not. Restarted Unity a couple times over this and encountered this with all three unchecked.
from protopromise.
Argh, looks it's on me! Had a bug causing reloads to keep going. Sorry brother!
from protopromise.
Should I just use the latest from main
? Seeing commits there and happy to help with testing, just want to understand what will be most helpful to you.
from protopromise.
fix-nullref-onapplicationquit
branch
from protopromise.
LGTM.
I reintroduced that bug that was causing a non-stop flood of image load reqs and no exceptions thrown on stopping the player.
from protopromise.
@drew-512 Thanks!
from protopromise.
Related Issues (20)
- Fatal error when building macOS player HOT 3
- `PromiseYielder.WaitOneFrame().ToPromise()` waits an extra frame.
- Add analyzer to prevent accidental misuse of `AsyncEnumerable`
- Add `Promise.ParallelForEachAsync`
- Add async Linq extensions for `AsyncEnumerable` HOT 1
- Add `AsyncEnumerable.Merge`
- Add `AsyncEnumerable` convenient generators
- Decouple Progress from Promises HOT 1
- Add `Promise.Finally` overloads that accept `Func<Promise>` delegates
- Add overloads that accept `Span<T>` parameter
- Update readme with instructions to install analyzer in Unity
- Add `Channel` type
- Add parallel async Linq
- Add Unity `Awaitable` conversion to `Promise`
- Add Promise groups
- the README and CHANGELOG for 3.0 have the wrong year HOT 1
- Add `Promise.Each` to process operations as they complete
- Add `Promise.GetRetainer()` API
- Compilation error if to use it together with plugin for "oidc-client" (needed for Azure auth) HOT 9
- Ability to Force Release Build in NuGet Target HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protopromise.