Comments (4)
kevingilbert100
commented on June 26, 2024
+1
from github-cognito-openid-wrapper.
TimothyJones
commented on June 26, 2024
Could this be fixed by removing the GITHUB_CLIENT_SECRET variable from the shim altogether and instead requiring that the service provider (i.e. Cognito) provides it?
This seems like a much better design, and I have no idea why I didn't do it that way in the first place. A PR that sorts this out would be very welcome.
Also, sorry I missed this when you first posted it, @ibtehajn!
from github-cognito-openid-wrapper.
shorn
commented on June 26, 2024
Alternate implementation based off of the wrapper that uses the client_secret to sign the JWT instead of a certificate: https://github.com/shorn/zinc/blob/main/aws-infra/lambda/doc/cognito-github.md
from github-cognito-openid-wrapper.
TimothyJones
commented on June 26, 2024
This seems like a much better design, and I have no idea why I didn't do it that way in the first place. A PR that sorts this out would be very welcome.
I know this is an old issue, but I was updating the dependencies for this project, and I remembered why the shim has its own secret- it's because otherwise you can't make the ID token.
It's possible you could still proxy the github secret all the way though, since I don't think it's involved in the token generation. This would be a simple change.
from github-cognito-openid-wrapper.
Related Issues (20)
- Bad id_token issuer HOT 3
- CDK as a deployment alternative HOT 2
- github accounts with 2FA fail HOT 3
- Can I use the access token to access the GitHub API? HOT 3
- Getting username attribute mapping required error HOT 3
- GitHub Error - 400 error getting token HOT 3
- Will I be able to consume the GitHub access_token? HOT 5
- Way to add GitHub OAuth scopes HOT 3
- GitHub App vs Github OAuth App HOT 2
- Failed to provide user info: Request failed with status code 403 HOT 6
- Question: Can the auth flow to GitHub be initiated without the Cognito Hosted UI? HOT 16
- Using cognito /logout endpoint not initiating new authn handshake with GitHub HOT 5
- Authenticating With GitHub MFA HOT 1
- Thoughts on how to update some custom claims coming from GitHub after the initial authorization in the OIDC flow HOT 3
- Undefined GITHUB_API_URL and GITHUB_LOGIN_URL HOT 1
- End of AWS Lambda support for nodejs10: July 30th HOT 2
- How to develop/test locally HOT 3
- How can I limit GitHub authentication only for users in my GitHub organization HOT 2
- Github App Compatibility HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-cognito-openid-wrapper.