Python 3.12 test failures: FAILED tests/test_tempfile.py::test_named_temporary_file[r+] - AttributeError: '_io.TextIOWrapper' object has no attribute 'delete' about aiofiles HOT 11 CLOSED

Interesting, thanks for doing this. Guess they changed the interface of these classes. Any idea of a remedy?

from aiofiles.

I'm afraid I don't have any. I'm just mass-testing Gentoo packages against Python 3.12 right now.

from aiofiles.

python/cpython@743453a#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21L470 is the change in question.

from aiofiles.

There is a new delete_on_close parameter for tempfile.NamedTemporaryFile in Python 3.12 that may be relevant, but I’m not prepared to wade through all the indirection to propose a patch at the moment.

from aiofiles.

I think I got this fixed on main! Let me know if I'm wrong.

from aiofiles.

I think I got this fixed on main! Let me know if I'm wrong.

Seems to work in Fedora Linux. Thanks!

from aiofiles.

I can also confirm that this fixes the problem for me. Could you make a new release, please? This change is a little big for us to backport to Gentoo.

from aiofiles.

I was hoping to wait until 3.12 was released in case they break us again, but I can release sooner.

from aiofiles.

Technically, 3.12 is in beta (and almost RC) already, so it shouldn't be breaking anything anymore.

from aiofiles.

@mgorny alright, I'm ready to release 23.2.0. Can you test once again with main before I do that?

from aiofiles.

@mgorny alright, I'm ready to release 23.2.0. Can you test once again with main before I do that?

Sure. It's all green. Thanks!

207 passed, 4 skipped in 2.61s

from aiofiles.