[User Still Receive Push Notification When Online] about chat HOT 4 CLOSED

Hi Riandy,

I think the comment in the code is incorrect but the code itself is correct. The code you pointed out collects device IDs which later are excluded. Take a look here https://github.com/tinode/chat/blob/devel/push_fcm/push_fcm.go#L73-L80
It skips the device IDs which were online and received the message. It sends to devices which were NOT online: https://github.com/tinode/chat/blob/master/push_fcm/push_fcm.go#L91

from chat.

The code you pointed out collects device IDs which later are excluded.

Yes, I’m aware of that. Hehe…

If we take a look at this block, we will see that the topic only exclude device ids which session is attached to that topic.

So for example, if user A is online by subscribing to “me” topic but he doesn’t subscribe to “topic_A”, then when there is new message in “topic_A”, user A will still receive push notification.

So in the end, user A would receive both {pres} & push notification.

This is the problem which I’m trying to address.

from chat.

So for example, if user A is online by subscribing to “me” topic but he doesn’t subscribe to “topic_A”, then when there is new message in “topic_A”, user A will still receive push notification.

Correct, the user will receive both {pres} and push. But I think that's the desired behavior. Is it not? I just checked Telegram and WhatsApp and both of them behaved in this exact way. It seems logical. What am I missing?

from chat.

Lol..🤣

Yeah, you’re right, Gene. I just checked it too. Whatsapp also have the same behavior.

I was under impression that push message should only be used when socket connection is not established between client & server. So I thought when user online, the server should not send push message towards the client.

But after observing Whatsapp, it is much better with this behavior. Because user become more aware that there is new message incoming 👍 .

Thanks a lot, Gene. Sorry to bother you. Lol.

from chat.