Use same color for fringe and line numbers about base16-emacs HOT 11 CLOSED

It seems that with this specific issue, there are a few different ways of handling this...

1. Leave it alone.
   Currently, there was a conscious decision to leave the fringe and line numbers different colors - similar to how the zenburn theme handles it (zenburn actually makes the line numbers match the text with a different color in the middle). This is actually how I like things to work. However, I'm just the maintainer, so if other people have strong opinions, I'm open to changing it.
2. Make the fringe match the text background.
   I really don't like how this one looks. For me the fringe and the numbers are more closely related.
3. Make the fringe match the line numbers
   I'm more open to this than choice 2. I've played around a bit with this and haven't gotten it to look good yet, but I'd be open to PRs.

from base16-emacs.

The problem with 1 is when you have something like the Spacemacs home buffer open, and have these borders on both sides. If you then open a NeoTree, for instance, it has a strangely wide border (because of the two fringes).

3 would be ideal (though only if the fringe were set to the text background for the right fringe, and buffers with no line numbers) but you would have to solve nashamri/spacemacs-theme#53.

In the absence of a solution to that, 2 is the best option. I have a fork that fixes this, but I don't want to submit a pull request until I can test it (right now, spacemacs won't let me use a theme from github, so I'm fixing it using the theming layer).

from base16-emacs.

Ah, right. Now I remember why I didn't do that here.

Also, my comment here describes why I'm not a fan of option 2: nashamri/spacemacs-theme#53 (comment) I use the fringe to find the start of the line... especially dealing with languages which are whitespace-sensitive (like python), having whitespace at the start of the line which isn't really there throws me off.

Unfortunately theming is a series of trade-offs, so things like this can be annoying to deal with.

Can you give a small screenshot of what you're seeing that you don't like?

Alternatively, you should be able to tweak this yourself and override some of the theme faces by using something like this:

(custom-theme-set-faces
 'base16-default-dark
 `(fringe ((t (:background ,(plist-get base16-default-dark-colors :base00))))))

from base16-emacs.

I'm doing precisely that to fix it right now, so I can't easily provide a screenshot.

In Python, you're comparing the indentation of the current line to the indentation of the previous block, so having exactly one space in front of every line doesn't change anything.

from base16-emacs.

Hi there, reviving this little issues for a question.

edit: I forgot to read the link posted earlier

First off - awesome package, really nice to be able to choose a base16 theme so easily.

I don't feel a huge need to change the colour of the fringe, but I'd love to have the line numbers and border the same colour as the background of the editor. Ie. if the area outlined in orange matched editor background.

I haven't written any lisp before, so if you feel like just giving some pointers / hints, I'd be happy to try it out when I have a bit more time :)

Thanks for any input!!

from base16-emacs.

from base16-emacs.

oh. hmm. woops. For some reason I thought the fringe was the ~ that go down a new line haha.

from base16-emacs.

By default I think those are in the fringe too.

EDIT: More specifically, of what you've highlighted the lighter portion is the fringe, while the darker portion is the gutter.

from base16-emacs.

Ah I see. Thanks for clarifying the terminology @beojan ...

Ideally both gutter and fringe would be dark ha! I'll mess around with my spacemacs file...

from base16-emacs.

Well, the new line-number faces in emacs might make me change this since they move the line numbers to the right of the fringe. I'll play around with it and see what looks good.

from base16-emacs.

I've added an option base16-distinct-fringe-background which defaults to true. If you change this to nil, it should be closer to what's been requested here. If you have any suggestions for improvements, I'd love to see them.

from base16-emacs.