Comments (8)
is that really a problem?
from co.
The second "like in browser" will slow down the code as call
is slower than a direct function call, plus, the current implementation does not require a function call at all (meaning, it's faster).
You should not yield anything else than a Promise, a GeneratorFunction
, a Function
or a plain Object
anyhow. So, when you say "may have a problem", what kind of problem do you have in mind? Can you give any example of a potential issue with the current implementation? I am all in favor of preventive maintenance, but if it creates bottle necks and does not improve the code in any way...
from co.
return val && 'Object' == val.constructor.name;
This one should fail if someone creates a constructor like this:
var Ctor = function () {}
Because .name
will not exist. This can be fixed by changing the expression to var Ctor = function Ctor() {}
; however, it is likely that it you'll see the first version instead.
from co.
@wilmoore , no, it will not fail, as co
is looking if the yielded object context is a function
before it checks if it's an Object
, So, no problem here.
from co.
as co is looking if the yielded object context is a function before
OH, cool. Well, that's fine then.
from co.
@juliangruber @yanickrochon if the object
is just a plain object
, that's ok.
If i want to yield a object through a constructor(eg. function A(a) {this.a=a}
, yield new A('aaa')
),
i think Object.prototype.toString.call(val) === '[object Object]'
is always okey.
ps. Actually, constructor
can be modified by you, so i think it is not safe. That's the reason that you use Array.isArray(val)
instead of Array == val.constructor
.
from co.
"If it ain't broke don't fix it"
Is there a use case where this fails?
from co.
yielding non-plain objects would be pretty weird and likely break in most cases, it's a pretty questionable feature in the first place haha, handy, but questionable
from co.
Related Issues (20)
- The co's then-function called before than thunkify function HOT 2
- Process yield undefined HOT 7
- Why can not choose Promise implement lib
- Using co in the browser HOT 1
- try/catch doesn't work HOT 1
- Set a sleep interval between each resolve? HOT 3
- there is something unsuitable about isGenerator and isObject function HOT 2
- Add `.finally` HOT 5
- Yielding to array of promises behavior
- isGeneratorFunction will return true when the obj is a generator
- Confused about the doc on yield generator
- Does it make sense to use control flow in the project's description?
- Promises still in the event Loop
- .catch and .then are both called when an exception is thrown HOT 2
- Add streams into yieldable list HOT 2
- why the objectToPromise function so complex ?
- Added type for `co`
- who can answer me ? what the 'co''s full name? thks! HOT 2
- .
- Why not support 'import'? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from co.