Date objects don't survive yield about co HOT 6 CLOSED

What did you expect to get by doing that? I'm missing the functionality

from co.

Assume foo has some other properties in it that are thunks to get later values. The Date objects in there will get reset in the yield.

Here's a more verbose example;

var assert = require('assert')
var co = require('co')

co(function* () {
  var foo = {
    other: function (done) {
      setTimeout(function () {
        done(null, 'delayed value')
      }, 100)
    },
    now: new Date
  }

  var bar = yield foo

  assert(bar.other === 'delayed value')
  assert(foo.now.getTime() === bar.now.getTime())
})()

foo.now and bar.now should contain the same Date object, so calling getTime() on either should return the same value. This is not the case currently. foo.now.getTime() will be equal to the time the foo object was created, while bar.now.getTime() will be equal to the time the yield resolved. The value gets reset.

from co.

I was looking at the tests and understand your issue:

it('should ignore non-thunkable properties', function(done){
    co(function *(){
      var res = yield {
        name: { first: 'tobi' },
        age: 2,
        address: read('index.js', 'utf8')
      };

      res.name.should.eql({ first: 'tobi' });
      res.age.should.equal(2);
      res.address.should.include('exports');
    })(done);
  })

from co.

Yeah, that stuff works fine. It's the Date object specifically that doesn't work. I'm guessing co needs some extra stuff to detect instances of things and not run them through the recursive object yielding stuff or something. Not sure exactly how that'd work.

from co.

The behavior is correct, in your example foo.now and bar.now have the same value.

Because Date is an object and not a primitive, it goes through objectToThunk, and a new Date object is created, so the assertion is invalid.

function objectToThunk(obj){
  var ctx = this;

   return function(done){
     var keys = Object.keys(obj);
     var pending = keys.length;
     var results = new obj.constructor();    <--  here is created a new Date object
     var finished;
...

I don't know if this is an issue, because the desired functionality is correct.

from co.

Breaking any object that normally takes arguments to initialize is correct behaviour?

It should probably do a obj.constructor === Object check or something before running that.

from co.