Contributing: use implicit attr=true about react-mdl HOT 4 CLOSED

👍

from react-mdl.

Another reason I can see this being very useful is, when doing a quick code scan, singling out true vs false will be much easier.

<Button colored={ true } ripple={ false } accent={ true }>
// vs
<Button colored ripple={ false } accent>

If changed, a separate discussion is whether "true" should be the default value for anything. Considering <Button ripple> makes it very clear that we are adding functionality rather than <Button ripple={ false }> to turn it off

from react-mdl.

I agree with removing the boolean values in jsx. I was forcing them in personal projects but the more I use them, the more I want them removed as well.

But yes, it would mean that all booleans should be false by default.
The only one that isn't false is the ripple effect, because I think people usually add it since it's part of the MDL so I thought I could save that to users

from react-mdl.

I did a first step which removes the boolean when it's true. I'll change the default for the ripple later.

from react-mdl.