FILPATHLEN became HAMLIB_FILPATHLEN in hamlib 4.2 about tlf HOT 10 CLOSED

Hi @jackhill,

thanks for the hit - could you try this quick fix?

@dl1jbe, @zcsahok - do we need to handle the other possibilities in sendqrg.h?

from tlf.

@airween Thanks for looking into it! I can confirm that I can build and run the tests with your branch and hamlib 4.2. I didn't test running it and connecting it to any radios (I'm working on creating a package of tlf for Guix and there are some unrelated things for me to clean up before I can do that test) or against an older hamlib.

de KM4MBG

from tlf.

Hi @jackhill,

thanks for confirmation. Please do not apply this patch in Guix while we do not merge into the master branch.

73, de HA2OS

from tlf.

Sounds reasonable. I'll wait to see what the final solution is and backup that fix or package a newer release when one is available. Thanks again!

from tlf.

Hi @jackhill,

thanks for the hit - could you try this quick fix?

@dl1jbe, @zcsahok - do we need to handle the other possibilities in sendqrg.h?

We should at least do a '#else' and '#error' after line 30 if neither macro is defined.

The whole situation with Hamlib breaking its public API (using FILPATHLEN was a recommended part of it) in a minor version bump is highly disappointing There are quite some more ham radio applications which will be affected by that move.

While we can fix it for new code it is still a problem for using hamlib-4.2 with existing released versions of TLF. Hopefully we can work around by using '-DFILPATHLEN=HAMLIB_FILPATHLEN' or similar during build.

from tlf.

Hi Thomas,

I thought about I put the check into the autoconfig script, but using of FILPATHLEN macro is very limited: it's only in the sendqrg.c (and the header now). That's why I chose this solution. Would you me to put it the configure.in?

from tlf.

Hi Ervin, think it should not be needed. We check for hamlib in configure.in and so either macro should be here. If not, then something is quite wrong and we should '#error' out in sendqrg.h

from tlf.

Thanks - did you think something like this?

If it's right, I'm going to send the PR.

from tlf.

Better

#error "(HAMLIB_)FILPATHLEN macro not found"

to catch both versions.
Otherwise feel free to PR and merge it in.

from tlf.

PR #268 has merged, it solves this issue.

from tlf.