Comments (10)
Hi @jackhill,
thanks for the hit - could you try this quick fix?
@dl1jbe, @zcsahok - do we need to handle the other possibilities in sendqrg.h?
from tlf.
@airween Thanks for looking into it! I can confirm that I can build and run the tests with your branch and hamlib 4.2. I didn't test running it and connecting it to any radios (I'm working on creating a package of tlf for Guix and there are some unrelated things for me to clean up before I can do that test) or against an older hamlib.
de KM4MBG
from tlf.
Hi @jackhill,
thanks for confirmation. Please do not apply this patch in Guix while we do not merge into the master branch.
73, de HA2OS
from tlf.
Sounds reasonable. I'll wait to see what the final solution is and backup that fix or package a newer release when one is available. Thanks again!
from tlf.
Hi @jackhill,
thanks for the hit - could you try this quick fix?
@dl1jbe, @zcsahok - do we need to handle the other possibilities in sendqrg.h?
We should at least do a '#else' and '#error' after line 30 if neither macro is defined.
The whole situation with Hamlib breaking its public API (using FILPATHLEN was a recommended part of it) in a minor version bump is highly disappointing There are quite some more ham radio applications which will be affected by that move.
While we can fix it for new code it is still a problem for using hamlib-4.2 with existing released versions of TLF. Hopefully we can work around by using '-DFILPATHLEN=HAMLIB_FILPATHLEN' or similar during build.
from tlf.
Hi Thomas,
I thought about I put the check into the autoconfig script, but using of FILPATHLEN
macro is very limited: it's only in the sendqrg.c
(and the header now). That's why I chose this solution. Would you me to put it the configure.in
?
from tlf.
Hi Ervin, think it should not be needed. We check for hamlib in configure.in and so either macro should be here. If not, then something is quite wrong and we should '#error' out in sendqrg.h
from tlf.
Thanks - did you think something like this?
If it's right, I'm going to send the PR.
from tlf.
Better
#error "(HAMLIB_)FILPATHLEN macro not found"
to catch both versions.
Otherwise feel free to PR and merge it in.
from tlf.
PR #268 has merged, it solves this issue.
from tlf.
Related Issues (20)
- Re-scoring does not consider QSO mode
- Enhance _Escape_ to stop message TX on first press HOT 37
- how to contribute with new contest rule HOT 8
- Review usage of fgets in file reading HOT 3
- Handling of user provided contest rule and multiplier files HOT 5
- INITIAL_EXCHANGE handling HOT 2
- Make boolean configs symmetric HOT 3
- tlf doesn't recognize folder with configuration HOT 5
- Using HAMLIB_KEYER makes other hamlib calls fail HOT 2
- Hamlib version depedency? HOT 6
- North American Exchange Hanling HOT 2
- Feature Request: Help me stay in my bandplan HOT 6
- Cannot build with latest (git) Hamlib HOT 2
- Tlf fails to build from source (FTBFS) against Hamlib Master HOT 1
- Remove CTCOMPATIBLE mode
- Feature request : CW keying via hamlib HOT 7
- Submitting contact with several multipliers HOT 6
- Use of 'getline' (PR 403) needs more work HOT 9
- Building without specific depedencies possible? HOT 3
- Sporadic lock-up on exit HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tlf.