Feature request Is your feature request related to a problem? Ple

The problem is that s_retention.py executes the

fixed by <a class="issue-link js-issue-link" data-error-text="Failed to load title" da

Add means to set default socket timeout to `scripts_retention.py` about tlsfuzzer HOT 5 CLOSED

ueno commented on May 20, 2024

Add means to set default socket timeout to `scripts_retention.py`

from tlsfuzzer.

Comments (5)

tomato42 commented on May 20, 2024

The problem is that scripts_retention.py executes the scripts as normal executables (it doesn't import them to execute), so it doesn't have any special impact on the runtime of it, it can only change environment variables and/or command line options.

Using the socket.setdefaulttimeout won't work because the default is always overriden:

tlsfuzzer/tlsfuzzer/messages.py

Lines 65 to 85 in dbd56c1

 def __init__(self, hostname, port, version=(3, 0), timeout=5): 

 """ 

  Provide minimal settings needed to connect to other peer. 

  :param str hostname: host name of the server to connect to 

  :param int port: :term:`TCP` port number to connect to 

  :param tuple(int,int) version: the protocol version used in the 

  record layer for the initial messages 

  :param float timeout: amount of time to wait while expecting a message 

  before aborting the connection, in seconds 

  """ 

 super(Connect, self).__init__() 

 self.hostname = hostname 

 self.port = port 

 self.version = version 

 self.timeout = timeout 

 def process(self, state): 

 """Connect to a server.""" 

 sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) 

 sock.settimeout(self.timeout)

Adding support for -t timeout to all script would be the better. Not sure why you think integration would be harder, there's support for common_arguments to pass -t timeout to all scripts (including option to override it on a per-script basis), e.g.:

tlsfuzzer/tests/tlslite-ng-random-subset.json

Lines 362 to 363 in dbd56c1

 "common_arguments" : ["-k", "tests/clientX509Key.pem", 

 "-c", "tests/clientX509Cert.pem"],

from tlsfuzzer.

ueno commented on May 20, 2024

there's support for common_arguments to pass -t timeout to all scripts (including option to override it on a per-script basis)

Oh, ok; I wasn't aware of that option.

Adding support for -t timeout to all script would be the better.

One more thing that might prevent this is that test-tls13-count-tickets.py uses -t for a different meaning (ticket count).

from tlsfuzzer.

tomato42 commented on May 20, 2024

One more thing that might prevent this is that test-tls13-count-tickets.py uses -t for a different meaning (ticket count).

hmm, technically it's reserved for the timeout:

tlsfuzzer/scripts/test-conversation.py

Lines 63 to 64 in dbd56c1

 # -t timeout to wait for messages (also count of NSTs in 

 # test-tls13-count-tickets.py)

but yes, that script is the exception, we may need to break compatibility on it

from tlsfuzzer.

tomato42 commented on May 20, 2024

I've been thinking a bit more about it, and I wonder if it really just wouldn't be better to change the timeout on that one (test-tls13-ffdhe-sanity.py) script (maybe even make its default larger in the script proper)...

The thing is that 5 seconds for a reply, especially on a localhost is quite generous, but this particular test runs through all the different FFDHE key sizes, and 8192 bit DH is really slow, so on an overwhelmed CI host I can imagine the calculation alone taking 5 seconds... At the same time, even the slowest ECDH should be faster by few orders of magnitude, same for 2048bit DH, so other scripts shouldn't really be impacted.

from tlsfuzzer.

tomato42 commented on May 20, 2024

fixed by #782

from tlsfuzzer.

Add means to set default socket timeout to `scripts_retention.py` about tlsfuzzer HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	def __init__(self, hostname, port, version=(3, 0), timeout=5):
	"""
	Provide minimal settings needed to connect to other peer.

	:param str hostname: host name of the server to connect to
	:param int port: :term:`TCP` port number to connect to
	:param tuple(int,int) version: the protocol version used in the
	record layer for the initial messages
	:param float timeout: amount of time to wait while expecting a message
	before aborting the connection, in seconds
	"""
	super(Connect, self).__init__()
	self.hostname = hostname
	self.port = port
	self.version = version
	self.timeout = timeout

	def process(self, state):
	"""Connect to a server."""
	sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
	sock.settimeout(self.timeout)

	"common_arguments" : ["-k", "tests/clientX509Key.pem",
	"-c", "tests/clientX509Cert.pem"],

	# -t timeout to wait for messages (also count of NSTs in
	# test-tls13-count-tickets.py)