Allow for multiple queryparam values about flurl HOT 6 CLOSED

Ok. I think they way I'll support it will look something like this:

url.SetQueryParam("include", new[] { "deleted", "spam", "approved" });

While technically a breaking change, it's highly unlikely to break anyone's implementation, since Flurl currently just does a ToString on whatever value is passed, which is pretty useless in the case of a list or array. Also note that SetQueryParam(s) overwrites if the key exists, so you won't be able to, say, set ["deleted", "spam"] first and then add "approved" in a later call. I could add some kind of support for that later if it's wanted but it feels like overkill for now.

Watch for this in the coming days.

from flurl.

Interesting case, I haven't run into that before. Perhaps passing an array or list as a query value should result in that behavior by default. I think that seems reasonable, and I'll tentatively add that in the coming days.

In the mean time, did you try using a comma-separated value with Disqus? i.e. include=deleted,spam,approved. That'd work with Flurl today. It's not documented, but you might get lucky.

Thanks for the good suggestion!

from flurl.

I did try that, but it failed. I tried it first with PostManClient to see what exactly was possible, but ended up in providing multiple queryparam values with same key.
Thanks for looking into that!

from flurl.

I love the suggestion. I resembles exactly what it needs to do.

from flurl.

This is now implemented in the latest NuGet package. Thanks again for the suggestion!

from flurl.

Thank you for implementing this, I have a similar use case.
It would be good if this was documented, at least for the overloaded method you could add a different description.

from flurl.