Comments (3)
Great catch. It turns out that the method I used to decode the URL has a glitch specific to the + character that has been blogged about by Rick Strahl and others. I will provide an update soon, most likely going with Rick's method. Thanks for reporting.
from flurl.
This is fixed almost to your liking.
- When parsing a query string, Flurl now interprets
+
as a space. - When encoding a query string, Flurl by default encodes spaces as %20, but
Url.ToString
now optionally takes anencodeSpaceAsPlus
argument so you can control it.
The only thing you don't get here is preserving the original intent, i.e. if it goes in as a +
it should come out as a +
. Flurl stores unencoded values and encodes as needed, and re-architecting it to remember the original encoding seemed like a large effort without much benefit. Servers will be perfectly happy with %20
if you're making HTTP calls, and if you want +
's for vanity you've got the ToString
overload. Hope this a satisfactory resolution.
Both Flurl and Flurl.Http have been upgraded with this change on NuGet.
from flurl.
Sounds good :-)
from flurl.
Related Issues (20)
- HttpTest WithRequestJson does not use JsonSerializer set on FlurlClientCache HOT 3
- Deadlock (or something weird) when calling `GetStringAsync` HOT 2
- 4.0.0 HOT 2
- System.EntryPointNotFoundException on PostJsonAsync HOT 1
- Add support for CancellationToken in IFlurlResponse asynchronous methods HOT 1
- Add option to disable conversion of plus signs to spaces for query parameters HOT 3
- According to RFC-7578 the Content-Disposition filename* parameter in multipart MUST NOT be used
- IFlurlClientBuilder.AddMiddleware cuts the chain of delegating handlers HOT 1
- Encode Issue HOT 2
- .net 8 blazor wasm PlatformNotSupportedException HOT 7
- GetJsonAsync<T> is not working after upgrading the Flurl Http to version 4 >= HOT 5
- The response ended prematurely HOT 2
- Trimming unused code causes the exception - Response could not be deserialized to JSON HOT 4
- Not able to configure Delegating handler in Flurl clientless DI configuration HOT 2
- Collection was modified; enumeration operation may not execute. HOT 1
- DownloadFileAsync => GetFileNameFromPath does not respect redirects HOT 1
- `OnRedirect` does not work with custom `HttpClient` HOT 4
- Serialization based on response status code HOT 1
- Support for Setting HttpRequestMessage.HttpVersionPolicy in FlurlHttpSettings
- SetQueryParam() parameters with the same name will be overwritten, either not overwritten or optionally overwritten HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flurl.